-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow searching by email and phone number in the contacts.search
endpoint
#34107
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 5476698 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34107 +/- ##
========================================
Coverage 75.75% 75.75%
========================================
Files 510 510
Lines 22078 22078
Branches 5387 5387
========================================
Hits 16726 16726
Misses 4706 4706
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed in favor of #34194 |
Proposed changes (including videos or screenshots)
email
andphone
query params to theomnichannel/contacts.search
endpoint, which allow applying an "exact match" search to these fields (in addition to the regex search that is currently applied when providing thesearchTerm
fields).Issue(s)
Steps to test or reproduce
Example request (cURL):
In case
searchTerm
is also provided, the endpoint will only return contacts that match the provided email/phone and the search term (which is compared to the contact name, emails and phones using regex)Further comments
SCI-147