Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused updateMessage meteor method #34104

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Dec 3, 2024

Proposed changes (including videos or screenshots)

Removes unused method from client

Issue(s)

ARCH-1347

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner December 3, 2024 13:46
Copy link
Contributor

dionisio-bot bot commented Dec 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@MartinSchoeler MartinSchoeler added this to the 7.2.0 milestone Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (2c2a35a) to head (6ac0534).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34104   +/-   ##
========================================
  Coverage    75.75%   75.75%           
========================================
  Files          510      510           
  Lines        22078    22078           
  Branches      5387     5387           
========================================
  Hits         16726    16726           
  Misses        4706     4706           
  Partials       646      646           
Flag Coverage Δ
unit 75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34104/
on branch gh-pages at 2024-12-03 13:49 UTC

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Dec 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2024
@kodiakhq kodiakhq bot merged commit e043d33 into develop Dec 3, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the remove-meteor-method/updateMessage branch December 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants