Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client trying to subscribe to streams before completing the login process #34089

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Nov 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

SUP-699

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 4192f23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review November 29, 2024 15:31
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner November 29, 2024 15:31
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34089/
on branch gh-pages at 2024-11-29 15:35 UTC

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (e043d33) to head (4192f23).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34089   +/-   ##
========================================
  Coverage    75.75%   75.75%           
========================================
  Files          510      510           
  Lines        22078    22078           
  Branches      5387     5387           
========================================
  Hits         16726    16726           
  Misses        4706     4706           
  Partials       646      646           
Flag Coverage Δ
unit 75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto
Copy link
Member

/backport 6.12.3

Copy link
Contributor

dionisio-bot bot commented Dec 2, 2024

Pull request #34099 added to Project: "Patch 6.12.3"

@scuciatto scuciatto added this to the 7.2.0 milestone Dec 2, 2024
@scuciatto
Copy link
Member

/backport 6.13.1

Copy link
Contributor

dionisio-bot bot commented Dec 2, 2024

Pull request #34100 added to Project: "Patch 6.13.1"

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Dec 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 3, 2024
@scuciatto scuciatto added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 3, 2024
@ggazzo ggazzo merged commit 486b33a into develop Dec 3, 2024
52 checks passed
@ggazzo ggazzo deleted the fix/streams-failing-to-subscribe-on-login branch December 3, 2024 19:18
@scuciatto
Copy link
Member

/backport 7.0.1

Copy link
Contributor

dionisio-bot bot commented Dec 4, 2024

Pull request #34114 added to Project: "Patch 7.0.1"

@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Dec 4, 2024

Pull request #34116 added to Project: "undefined"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants