Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videoconf ringer fails to accept calls after a logout/login #34068

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Nov 27, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • User 1 and User 2 are logged on Rocket.Chat
  • User 2 logs out and logs back in on the same tab, without refreshing the page
  • User 2 calls User 1
  • User 1 accepts
  • The call stops ringing for User 1, but for User 2 it continues to show as if it was ringing

Further comments

CORE-839

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review November 27, 2024 15:43
Copy link
Contributor

dionisio-bot bot commented Nov 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: f9d20ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner November 27, 2024 15:43
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (3afcb8d) to head (f9d20ba).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34068   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34068/
on branch gh-pages at 2024-11-27 19:37 UTC

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Nov 27, 2024
@aleksandernsilva aleksandernsilva added this to the 7.2.0 milestone Nov 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 27, 2024
@kodiakhq kodiakhq bot merged commit fd44a8b into develop Nov 27, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/videoconf-ringer-fails-after-logout branch November 27, 2024 20:24
@scuciatto
Copy link
Member

/backport 6.12.3

Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Pull request #34072 added to Project: "undefined"

@scuciatto
Copy link
Member

/backport 6.13.1

Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Pull request #34074 added to Project: "undefined"

@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Pull request #34075 added to Project: "Patch 7.0.1"

@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Dec 4, 2024

Pull request #34117 added to Project: "Patch 7.1.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants