feat: Workspace/subscription ux #34057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WorkspaceCardSection component was updated to improve typography and clarify title differentiation. The header titles now use the h4 font scale, while the section titles have been updated to use the p2b font scale. Additionally, the default font scale of the component text was changed to p2. A new boolean property was also added to differentiate between header titles and section titles, ensuring consistent styling and clearer hierarchy.
…rtically and horizontally
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b519f1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rique223
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34057 +/- ##
============================================
+ Coverage 59.28% 75.27% +15.99%
============================================
Files 2821 516 -2305
Lines 67945 22540 -45405
Branches 15109 5485 -9624
============================================
- Hits 40282 16968 -23314
+ Misses 24831 4911 -19920
+ Partials 2832 661 -2171
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
rique223
changed the title
ggazzo
reviewed
Nov 28, 2024
apps/meteor/client/views/admin/subscription/components/cards/PlanCard/PlanCardCommunity.tsx
Show resolved
Hide resolved
ggazzo
reviewed
Nov 28, 2024
apps/meteor/client/views/admin/workspace/components/WorkspaceCardSection.tsx
Outdated
Show resolved
Hide resolved
Componentized the WorkspaceCardSection title and refactored the WorkspaceCardSectionTitle to accept the new title.
The version card background image has been updated to better align with design specifications. On large screens and smaller, the image is fixed to the right side of the container and gradually crops from the right as the container shrinks. On extra-large screens and larger, it remains fixed to the right side with a 20px margin from the container's edge.
|
if reflects in ui/ux changes is not a refactor, also requires changeset |
aleksandernsilva
requested changes
Dec 3, 2024
apps/meteor/client/views/admin/subscription/SubscriptionPage.tsx
Outdated
Show resolved
Hide resolved
rique223
changed the title
…tChat/Rocket.Chat into refactor/workspace-subscription-ux
juliajforesti
requested changes
Dec 4, 2024
apps/meteor/client/views/admin/subscription/components/FeatureUsageCard.tsx
Outdated
Show resolved
Hide resolved
ggazzo
changed the title
juliajforesti
requested changes
Dec 16, 2024
apps/meteor/client/views/admin/subscription/components/cards/ActiveSessionsCard.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/subscription/components/cards/ActiveSessionsPeakCard.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/subscription/components/cards/AppsUsageCard/AppsUsageCard.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/workspace/UsersUploadsCard/UsersUploadsCard.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/workspace/components/WorkspaceCardSectionTitle.tsx
Outdated
Show resolved
Hide resolved
|
just a reminder: if it changes something to the end user it shouldn't be a chore |
rique223
changed the title
Removed the titleToContentGap prop as the margin-block-end of all h4 titles are 20px anyways so this can be done with a simple ternary.
juliajforesti
approved these changes
Dec 17, 2024
tassoevan
approved these changes
Dec 19, 2024
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
aleksandernsilva
approved these changes
Dec 19, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
KevLehman
added
the
stat: ready to merge
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
p2, the fontScale of the WorkspaceCardSection title top2band the fontScale of the WorkspaceCardSection header titles toh4;verticallyandhorizontally;horizontally;244pxto the cards and changed the margin between the community card content to be8px;Demos:
Workspace page:
FontScale and spacing changes
Change responsivity strategy
Subscription page:
Centralize content vertically and horizontally
Change spacing for community card and apps card. Add 244px "min-height" to all the cards
Centralize content horizontally
Issue(s)
Steps to test or reproduce
Further comments
Jira tasks:
CONN-413: Workspace font size
CONN-414: Version card background image responsivity
CONN-415: Centralize seats and MAC
CONN-417: Subscription page spacing
CONN-418: Centralize active sessions and active sessions peak