Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop unused type declarations and type exports #34055

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It removes type declarations and type exports that became obsolete and forgetten in the codebase.

Issue(s)

Steps to test or reproduce

Further comments

It was extracted from to simplify review.

Copy link
Contributor

dionisio-bot bot commented Nov 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: b95d6d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added this to the 7.2.0 milestone Nov 25, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34055/
on branch gh-pages at 2024-11-25 18:48 UTC

@tassoevan tassoevan marked this pull request as ready for review November 25, 2024 18:54
@tassoevan tassoevan requested review from a team as code owners November 25, 2024 18:54
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (b8388ab) to head (b95d6d0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34055   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@kodiakhq kodiakhq bot merged commit 8ade81b into develop Nov 25, 2024
56 checks passed
@kodiakhq kodiakhq bot deleted the refactor/unused-types branch November 25, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants