Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove meteor.startup from permalink-star #34022

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Nov 21, 2024

Copy link
Contributor

dionisio-bot bot commented Nov 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: ae1b3b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 7.2.0 milestone Nov 21, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34022/
on branch gh-pages at 2024-11-21 18:46 UTC

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (0d5f794) to head (ae1b3b2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34022   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@MartinSchoeler MartinSchoeler marked this pull request as ready for review November 21, 2024 19:24
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner November 21, 2024 19:24
dougfabris
dougfabris previously approved these changes Nov 22, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tassoevan
tassoevan previously approved these changes Nov 22, 2024
@tassoevan tassoevan force-pushed the remove-meteor-startup/permalinkStar branch from 94d0227 to 387385e Compare November 22, 2024 22:25
@tassoevan tassoevan dismissed stale reviews from dougfabris and themself via af39619 November 25, 2024 00:35
@tassoevan tassoevan force-pushed the remove-meteor-startup/permalinkStar branch from 387385e to af39619 Compare November 25, 2024 00:35
@tassoevan tassoevan merged commit dbdb521 into develop Nov 25, 2024
49 checks passed
@tassoevan tassoevan deleted the remove-meteor-startup/permalinkStar branch November 25, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants