feat: keep VoIP history #34004
Merged
feat: keep VoIP history #34004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8a033a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
sampaiodiego
requested changes
Nov 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34004 +/- ##
===========================================
- Coverage 75.83% 75.22% -0.62%
===========================================
Files 511 514 +3
Lines 22172 22429 +257
Branches 5397 5474 +77
===========================================
+ Hits 16814 16872 +58
- Misses 4710 4904 +194
- Partials 648 653 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Dec 16, 2024
apps/meteor/ee/server/local-services/voip-freeswitch/service.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/server/local-services/voip-freeswitch/service.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/server/local-services/voip-freeswitch/service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
KevLehman
force-pushed
the
feat/voip-history
branch
from
bc07c54 to
0d68521
Compare
MarcosSpessatto
previously approved these changes
Dec 19, 2024
sampaiodiego
requested changes
Dec 19, 2024
There was a problem hiding this comment.
should I receive this error on console when starting up rocket.chat with nothing configured?
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) Error: VoIP is disabled.
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at VoipFreeSwitchService.getConnectionSettings (ee/server/local-services/voip-freeswitch/service.ts:40:10)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at VoipFreeSwitchService.started (ee/server/local-services/voip-freeswitch/service.ts:31:10)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at /Users/diegosampaio/dev/Rocket.Chat/packages/core-services/src/LocalBroker.ts:115:65
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at Array.map (<anonymous>)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at LocalBroker.start (/Users/diegosampaio/dev/Rocket.Chat/packages/core-services/src/LocalBroker.ts:115:40)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at Api.start (/Users/diegosampaio/dev/Rocket.Chat/packages/core-services/src/lib/Api.ts:75:21)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at module.wrapAsync.self (server/startup/localServices.ts:12:10)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at Module.wrapAsync (/Users/diegosampaio/.meteor/packages/modules/.0.20.2.1rksah5.q497++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/@meteorjs/reify/lib/runtime/index.js:252:8)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at module (/Users/diegosampaio/dev/Rocket.Chat/apps/meteor/.meteor/local/build/programs/server/app/app.js:241370:9)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at fileEvaluate (packages/modules-runtime.js:335:7)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at Module.require (packages/modules-runtime.js:237:14)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at Module.mod.require (/Users/diegosampaio/.meteor/packages/modules/.0.20.2.1rksah5.q497++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/@meteorjs/reify/lib/runtime/index.js:30:33)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at require (packages/modules-runtime.js:257:21)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at startup (server/startup/index.ts:20:3)
@rocket.chat/meteor:dsv: W20241219-14:48:59.026(-3)? (STDERR) at processTicksAndRejections (node:internal/process/task_queues:95:5)
@rocket.chat/meteor:dsv: W20241219-14:48:59.027(-3)? (STDERR) at async Promise.all (index 3)
@rocket.chat/meteor:dsv: W20241219-14:48:59.027(-3)? (STDERR) at module.wrapAsync.self (server/main.ts:28:1)
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
requested changes
Dec 20, 2024
apps/meteor/ee/server/local-services/voip-freeswitch/service.ts
Outdated
Show resolved
Hide resolved
sampaiodiego
requested changes
Dec 20, 2024
apps/meteor/ee/server/local-services/voip-freeswitch/service.ts
Outdated
Show resolved
Hide resolved
sampaiodiego
approved these changes
Dec 20, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Core-775
Steps to test or reproduce
Further comments