-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UsersTable): mark remote users' registration as "Federated" instead of "Pending" #33873
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 94c2e04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33873 +/- ##
========================================
Coverage 75.83% 75.83%
========================================
Files 511 511
Lines 22172 22172
Branches 5397 5397
========================================
Hits 16814 16814
Misses 4710 4710
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Federated couldn't be Pending or Deactivated for any another reason? a federated user is always registered as federated for ever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
Issue(s)
SUP-630
Steps to test or reproduce
Further comments