fix: broken client-side updates for recent emoji list

[abhinavkrin]

Proposed changes (including videos or screenshots)

This PR fixes the broken client-side updates for recent emoji list when custom emojis are modified.

Currently, we are calling updateRecent with hard coded string value 'rocket' which inserts the rocket emoji whenever a custom emoji changes. Instead, the update in the recent emoji list should reflect an updated custom emoji or remove a deleted custom emoji from the recent list:

Rocket.Chat/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts

Line 52 in 5fddfcc

updateRecent(['rocket']);

same here:

Rocket.Chat/apps/meteor/app/emoji-custom/client/lib/emojiCustom.ts

Line 97 in 5fddfcc

updateRecent(['rocket']);

Issue(s)

Steps to test or reproduce

Further comments

CORE-690

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: f73b21a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33808/
on branch gh-pages at 2024-11-07 16:13 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (b4841cb) to head (f73b21a).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33808      +/-   ##
===========================================
- Coverage    75.42%   75.20%   -0.22%     
===========================================
  Files          493      495       +2     
  Lines        21499    21595      +96     
  Branches      5337     5362      +25     
===========================================
+ Hits         16215    16240      +25     
- Misses        4644     4713      +69     
- Partials       640      642       +2     

Flag	Coverage Δ
unit	75.20% <85.71%> (-0.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.