Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect validation for networking permission on Deno process #33786

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Oct 25, 2024

Proposed changes (including videos or screenshots)

Validation to determine whether to give the Deno subprocess networking access was incorrect

Issue(s)

CONN-405

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 4a05f8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33786/
on branch gh-pages at 2024-10-31 04:06 UTC

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (c2a48e3) to head (4a05f8f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33786   +/-   ##
========================================
  Coverage    75.40%   75.40%           
========================================
  Files          493      493           
  Lines        21487    21487           
  Branches      5336     5336           
========================================
  Hits         16202    16202           
  Misses        4645     4645           
  Partials       640      640           
Flag Coverage Δ
unit 75.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 7.1.0 milestone Oct 28, 2024
@d-gubert d-gubert marked this pull request as ready for review October 29, 2024 20:34
@d-gubert d-gubert requested a review from a team as a code owner October 29, 2024 20:34
@debdutdeb debdutdeb added the stat: QA assured Means it has been tested and approved by a company insider label Oct 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 31, 2024
@kodiakhq kodiakhq bot merged commit 3569b0a into develop Oct 31, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/deno-network-perm-verification branch October 31, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants