-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect validation for networking permission on Deno process #33786
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4a05f8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33786 +/- ##
========================================
Coverage 75.40% 75.40%
========================================
Files 493 493
Lines 21487 21487
Branches 5336 5336
========================================
Hits 16202 16202
Misses 4645 4645
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Validation to determine whether to give the Deno subprocess networking access was incorrect
Issue(s)
CONN-405
Steps to test or reproduce
Further comments