Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove hideRoom client meteor method #33766

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 24, 2024

Proposed changes (including videos or screenshots)

This PR removes hideRoom meteor method and unifies hide room calls across the application.

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1340

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 908428b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33766/
on branch gh-pages at 2024-11-27 14:19 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (3a66c37) to head (908428b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33766   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          510      510           
  Lines        22063    22063           
  Branches      5385     5385           
========================================
  Hits         16723    16723           
  Misses        4694     4694           
  Partials       646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the chore/remove-hide-room-method branch 2 times, most recently from 6f6c56c to 8637ced Compare October 30, 2024 18:37
@aleksandernsilva aleksandernsilva changed the title chore: Remove hideRoom meteor method chore: Remove hideRoom client meteor method Oct 30, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review November 11, 2024 20:58
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner November 11, 2024 20:58
@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Nov 11, 2024
apps/meteor/client/hooks/useRoomCloseAction.tsx Outdated Show resolved Hide resolved
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice working creating the new action hook using the mutation! I have a feeling that we should keep using hide in the name, despite the name of the endpoint we don't use to say "we closed the room", so in terms of dev exp should be better to recognize.

I realized we're missing the optimistic update the old client method does, we should implement it in the new mutation. Here's a reference on how to do it using react-query

@aleksandernsilva aleksandernsilva force-pushed the chore/remove-hide-room-method branch from fa7206d to 802172b Compare November 21, 2024 13:44
@aleksandernsilva aleksandernsilva modified the milestones: 7.1.0, 7.2.0 Nov 21, 2024
@aleksandernsilva aleksandernsilva force-pushed the chore/remove-hide-room-method branch from ff1da07 to 88969d9 Compare November 22, 2024 13:04
dougfabris
dougfabris previously approved these changes Nov 22, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really cool refactoring job!

@aleksandernsilva aleksandernsilva dismissed tiagoevanp’s stale review November 22, 2024 16:41

@tiagoevanp as discussed useMutation() won't be affected by the v5 upgrade

@tassoevan tassoevan force-pushed the chore/remove-hide-room-method branch from 8a37af4 to 971ffd6 Compare November 25, 2024 18:18
@tassoevan tassoevan force-pushed the chore/remove-hide-room-method branch from 971ffd6 to fb7516b Compare November 25, 2024 19:09
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Nov 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 27, 2024
@kodiakhq kodiakhq bot merged commit 8420101 into develop Nov 27, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-hide-room-method branch November 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants