Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove debian and preview images #33728

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 23, 2024

https://rocketchat.atlassian.net/browse/ARCH-1318

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 96b33fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33728/
on branch gh-pages at 2024-10-30 17:18 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (6dca2b0) to head (96b33fc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33728   +/-   ##
========================================
  Coverage    75.40%   75.40%           
========================================
  Files          493      493           
  Lines        21487    21487           
  Branches      5336     5336           
========================================
  Hits         16202    16202           
  Misses        4645     4645           
  Partials       640      640           
Flag Coverage Δ
unit 75.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the ci/adjust-docker-images-based-on-arch branch from 0fd3ea0 to f76016f Compare October 23, 2024 18:42
@ggazzo ggazzo changed the title ci: using base image instead of official on ci ci: Remove debian image base fallback Oct 28, 2024
@ggazzo ggazzo added this to the 7.1.0 milestone Oct 30, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 30, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 30, 2024
@ggazzo ggazzo marked this pull request as ready for review October 30, 2024 15:53
@ggazzo ggazzo requested a review from a team as a code owner October 30, 2024 15:53
@ggazzo ggazzo changed the title ci: Remove debian image base fallback ci: Remove debian and preview images Oct 30, 2024
@ggazzo ggazzo merged commit c2a48e3 into develop Oct 30, 2024
46 of 49 checks passed
@ggazzo ggazzo deleted the ci/adjust-docker-images-based-on-arch branch October 30, 2024 21:08
Gustrb pushed a commit that referenced this pull request Nov 4, 2024
Co-authored-by: Debdut Chakraborty <debdutdeb@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants