Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate more modules to TypeScript #33636

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

tassoevan
Copy link
Contributor

ARCH-1299

Proposed changes (including videos or screenshots)

It migrates some JavaScript modules to TypeScript.

Issue(s)

Steps to test or reproduce

Further comments

Pre-existent runtime errors are NOT addressed by this PR.

@tassoevan tassoevan added this to the 7.0 milestone Oct 18, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 10fcf4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (085fa5e) to head (10fcf4b).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33636   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21019    21019           
  Branches      5334     5334           
========================================
  Hits         15760    15760           
  Misses        4630     4630           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33636/
on branch gh-pages at 2024-10-19 04:24 UTC

@tassoevan tassoevan force-pushed the refactor/migrate-more-to-ts branch from 2cec073 to 82b9bbb Compare October 18, 2024 03:39
@tassoevan tassoevan marked this pull request as ready for review October 18, 2024 13:55
@tassoevan tassoevan requested review from a team as code owners October 18, 2024 13:55
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
Copy link
Contributor

kodiakhq bot commented Oct 18, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@tassoevan tassoevan force-pushed the refactor/migrate-more-to-ts branch from a4c01a3 to 2335d92 Compare October 18, 2024 22:22
@tassoevan tassoevan added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Oct 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 19, 2024
@tassoevan tassoevan force-pushed the refactor/migrate-more-to-ts branch from 2335d92 to 10fcf4b Compare October 19, 2024 04:12
@ggazzo ggazzo removed this from the 7.0 milestone Oct 21, 2024
@ggazzo ggazzo added this to the 7.1.0 milestone Oct 21, 2024
@ggazzo ggazzo merged commit 5fddfcc into develop Oct 21, 2024
51 checks passed
@ggazzo ggazzo deleted the refactor/migrate-more-to-ts branch October 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants