Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Rollback admin/workspace route to admin/info #30648

Merged
merged 8 commits into from
Oct 23, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Oct 16, 2023

Proposed changes (including videos or screenshots)

Jira task: WM-183

Changed the workspace page route from admin/workspace back to admin/info since this route change broke the mobile version of Rocket chat.

Demo image:
image

Issue(s)

Steps to test or reproduce

Further comments

Changed the workspace page route from admin/workspace back to admin/info since this route change broke the mobile version of the system.
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: d3d4110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #30648 (d3d4110) into develop (ad7e52b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30648      +/-   ##
===========================================
- Coverage    51.22%   51.14%   -0.08%     
===========================================
  Files          811      809       -2     
  Lines        15113    15218     +105     
  Branches      2759     2827      +68     
===========================================
+ Hits          7741     7784      +43     
- Misses        6961     6994      +33     
- Partials       411      440      +29     
Flag Coverage Δ
e2e 48.45% <ø> (-0.03%) ⬇️
unit 63.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 marked this pull request as ready for review October 17, 2023 16:48
@rique223 rique223 requested a review from a team as a code owner October 17, 2023 16:48
@rique223 rique223 requested a review from hugocostadev October 17, 2023 16:48
@rique223 rique223 added the squad: Workspace Management squad: Workspace Management label Oct 23, 2023
@casalsgh casalsgh added stat: ready to merge PR tested and approved waiting for merge stat: QA skipped and removed stat: needs QA labels Oct 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@casalsgh casalsgh added this to the 6.4.4 milestone Oct 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@kodiakhq kodiakhq bot merged commit 696629c into develop Oct 23, 2023
@kodiakhq kodiakhq bot deleted the regression/info-page-route branch October 23, 2023 22:43
@casalsgh casalsgh modified the milestones: 6.4.4, 6.4.3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants