Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Teams Channels #21248

Merged
merged 32 commits into from
Mar 23, 2021
Merged

[NEW] Teams Channels #21248

merged 32 commits into from
Mar 23, 2021

Conversation

tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp marked this pull request as ready for review March 23, 2021 12:50
@tiagoevanp tiagoevanp requested a review from a team March 23, 2021 12:51
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing a channel from the Team is not updating the channel list

Clicking a channel is not redirecting the user to that channel

Clicking the auto-join is not reactive, although it shows correctly after refreshing

The channel autocomplete in the add existing is not working

packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
definition/IRoom.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request fixes 2 alerts when merging 50d848e into d91cac2 - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@tassoevan tassoevan merged commit 44a6721 into new/teams Mar 23, 2021
@tassoevan tassoevan deleted the new/teams-channels branch March 23, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants