[FIX] Status message doesn't change once a custom status is set #21245

[Kartik18g]

• I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
• I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

When a user sets custom status and then changes it afterwards to one of the presets "busy", "away", "invisible" or "online", the status message doesn't change according to the preset values instead stays set to the custom message. Now whenever a preset is status is selected the status and it's message changes to the correct status value.

Previously

Screen.Recording.2021-03-22.at.5.47.34.PM.mov

Now

Screen.Recording.2021-03-22.at.6.53.21.PM.mov

Issue(s)

#21245

Steps to test or reproduce

Further comments

[yash-rajpal]

@Kartik18g This was an intentional change, its not a bug. Earlier the custom status used to work like you describe but it was changed in #20869 or #20613

[Kartik18g]

Oh! thanks for the heads up @yash-rajpal