[BREAK] Change apps/icon endpoint to return app's icon and use it to show on Ui Kit modal #16522
Conversation
| @@ -516,6 +516,33 @@ export class AppsRestApi { | |||
| }, | |||
| }); | |||
|
|
|||
| this.api.addRoute('icon/:id', { authRequired: false }, { | |||
There was a problem hiding this comment.
I know I can be hated for this because there is another endpoint :id/icon already: https://github.com/RocketChat/Rocket.Chat/pull/16522/files#diff-1d7b87614deb7cd95b3cfaa7420842a7R506
There was a problem hiding this comment.
IIRC the other one is not used anywhere? 🤔 I think I've searched for it before and haven't found anything. If that's the case, you can just change the behavior of the other one 😬
There was a problem hiding this comment.
Since we're targeting a major version, I could introduce this breaking change.
| @@ -134,7 +133,7 @@ export const modalBlockWithContext = ({ | |||
| <Modal open id={id} ref={ref}> | |||
| <Modal.Header> | |||
| {/* <Modal.Thumb url={`api/apps/${ context.appId }/icon`} /> */} | |||
| <Modal.Thumb url={thumb} /> | |||
| <Modal.Thumb url={`/api/apps/icon/${ data.appId }`} /> | |||
There was a problem hiding this comment.
this is not the best way to get the full URL, pls advice
There was a problem hiding this comment.
there is a context to set the prefix path
There was a problem hiding this comment.
I have found:
but looks like I cannot use it because you're not using ServerProvider that implements it:
what should I do?
There was a problem hiding this comment.
idk the advantages using a context, so I changed to use getURL that is widely used.
|
My hero |
sampaiodiego
changed the title
| const { name, iconFileContent } = app.getInfo(); | ||
|
|
||
| Object.assign(interaction, { | ||
| appInfo: { name, base64Icon: iconFileContent }, |
…5997-ritwizsinha-15996 * 'develop' of github.com:RocketChat/Rocket.Chat: (181 commits) Update Livechat widget dependency version to 1.3.1. (RocketChat#16580) Update Apps-Engine version (RocketChat#16584) [FIX] Error when successfully joining room by invite link (RocketChat#16571) Add breaking notice regarding TLS (RocketChat#16575) [FIX] Invite links proxy URLs not working when using CDN (RocketChat#16581) Regression: Modal onSubmit (RocketChat#16556) Regression: UIkit input states (RocketChat#16552) [FIX] Do not stop on DM imports if one of users was not found (RocketChat#16547) [FIX] Introduce AppLivechatBridge.isOnlineAsync method (RocketChat#16467) Regression: UIKit missing select states: error/disabled (RocketChat#16540) [BREAK] Change apps/icon endpoint to return app's icon and use it to show on Ui Kit modal (RocketChat#16522) Regression: update package-lock (RocketChat#16528) Regression: Update Uikit (RocketChat#16515) Regression: UIKit - Send container info on block actions triggered on a message (RocketChat#16514) Use base64 for import files upload to prevent file corruption (RocketChat#16516) Regression: Ui Kit messaging issues RocketChat#16513 Regression: Send app info along with interaction payload to the UI (RocketChat#16511) Fix: License missing from manual register handler (RocketChat#16505) Exclude federated and app users from active user count (RocketChat#16489) Remove users.info being called without need (RocketChat#16504) ...
Use the endpoint to show app's icon instead of returning it via websockets