Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert message properties validation #16395

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Revert message properties validation #16395

merged 2 commits into from
Jan 31, 2020

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jan 31, 2020 •
edited by sampaiodiego
Loading

Closes #16382
Closes #16345
Closes #16291

Revert validation for fields alias, avatar.

@MarcosSpessatto MarcosSpessatto added this to the 3.0.0 milestone Jan 31, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2020

This pull request introduces 1 alert when merging bd45652 into 5c0490f - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

sampaiodiego
sampaiodiego requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the last from this call as well

Rocket.Chat/app/lib/server/methods/sendMessage.js

Line 76 in 5bbd7d7

return sendMessage(user, message, room, false, trustedSender);

@sampaiodiego sampaiodiego changed the title [REGRESSION] Revert message properties (alias, avatar) validation Revert message properties validation Jan 31, 2020
@sampaiodiego sampaiodiego merged commit c170dde into develop Jan 31, 2020
@sampaiodiego sampaiodiego deleted the revert-message-validation branch January 31, 2020 22:26
sampaiodiego pushed a commit that referenced this pull request Jan 31, 2020
@MarcosSpessatto @sampaiodiego
Revert message properties validation (#16395)
a417b52
@sampaiodiego sampaiodiego mentioned this pull request Jan 31, 2020
Merged
@sampaiodiego sampaiodiego modified the milestones: 3.0.0, 2.4.6 Jan 31, 2020
ggazzo added a commit that referenced this pull request Feb 1, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into uikit
242f820 
* 'develop' of github.com:RocketChat/Rocket.Chat:
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
8fc703e 
…exact_search

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
f0ca4b6 
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'uikit' into ui-kit.2.0-turbo
f42cb4a 
* uikit:
  update package-lock.json
  Fix package-lock
  handle app errors
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  fuselage update
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  Update Apps-Engine version
  Update package.json
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
6663679 
…readmessages

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
568f048 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  ...
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
03fe860 
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  fix group
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  fix group messages
@MarcosSpessatto MarcosSpessatto mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
type: regression
Projects
None yet
Milestone
2.4.6
2 participants
@MarcosSpessatto @sampaiodiego