[NEW] WIP: custom mention groups #16311

maciek134 · 2020-01-22T22:30:29Z

Don't mind the commit message, it will be rebased.

Closes RocketChat/feature-requests#634

This implements custom mention groups. When creating a group an admin can set:

name
description
whether the group also notifies a specific role
whether the group also notifies a specific group (so in combination with a few other options you can make a transparent copy that notifies offline users too)
whether users can join this group themselves WIP
whether the group notifies offline people (like @all vs @here)
whether the group notifies people outside a channel
whether the group works in specific channels only

Here is an example of how it looks like for the user:

WIP:

I need to finish adding tests, at the moment the coverage of these features is close to zero
I need to finish UI for allowing users to assign themselves to the groups that have it enabled
missing translations

lgtm-com · 2020-01-22T22:42:38Z

This pull request introduces 7 alerts when merging 85b9672 into bf17f4c - view on LGTM.com

new alerts:

7 for Unused variable, import, function or class

fdellwing · 2020-01-23T10:47:25Z

I rly would like to test it, but I'm somehow unable to start RC from your fork.

Error Log

[11:16 root@FADE-Test Rocket.Chat] (feat/group-notifications) > meteor --allow-superuser npm start

Even with METEOR_ALLOW_SUPERUSER or --allow-superuser, permissions in your app directory will be incorrect if you ever attempt to perform any Meteor tasks as a normal user. If you need to fix your permissions, run the following command
from the root of your project:

  sudo chown -Rh <username> .meteor/local

                                              
> Rocket.Chat@2.5.0-develop start /root/Rocket.Chat
> meteor


Even with METEOR_ALLOW_SUPERUSER or --allow-superuser, permissions in your app directory will be incorrect if you ever attempt to perform any Meteor tasks as a normal user. If you need to fix your permissions, run the following command
from the root of your project:

  sudo chown -Rh <username> .meteor/local

[[[[[ ~/Rocket.Chat ]]]]]                     

=> Started proxy.                             
WARNING: npm peer requirements (for juliancwirko:postcss) not installed:
 - postcss@7.0.6 installed, postcss@^6.0.22 needed
 - postcss-load-config@2.0.0 installed, postcss-load-config@^1.2.0 needed

Read more about installing npm peer dependencies:
  http://guide.meteor.com/using-packages.html#peer-npm-dependencies

=> Meteor 1.9 is available. Update this project with 'meteor update'.
=> Started MongoDB.                           
Browserslist: caniuse-lite is outdated. Please run next command `npm update`
/root/.meteor/packages/coffeescript/.1.0.17.mg38nj.fxnij++os+web.browser+web.cordova/plugin.compileCoffeescript.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:116
      throw error;
      ^

Error: spawn ENOMEM
    at ChildProcess.spawn (internal/child_process.js:313:11)
    at exports.spawn (child_process.js:508:9)
    at exports.execFile (child_process.js:218:15)
    at resolve (/root/.meteor/packages/meteor-tool/.1.8.3.g4mka5.pvict++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/fs/tools/fs/files.ts:141:7)
    at new Promise (<anonymous>)
    at Object.findGitCommitHash (/root/.meteor/packages/meteor-tool/.1.8.3.g4mka5.pvict++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/fs/tools/fs/files.ts:138:10)
    at /tools/isobuild/bundler.js:2963:66
    at /tools/isobuild/bundler.js:3370:22
    at Object.capture (/tools/utils/buildmessage.js:283:5)
    at bundle (/tools/isobuild/bundler.js:3185:31)
    at files.withCache (/tools/isobuild/bundler.js:3130:32)
    at Slot.withValue (/root/.meteor/packages/meteor-tool/.1.8.3.g4mka5.pvict++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/@wry/context/lib/context.js:73:29)
    at Object.withCache (/root/.meteor/packages/meteor-tool/.1.8.3.g4mka5.pvict++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/fs/tools/fs/files.ts:1647:39)
    at Object.bundle (/tools/isobuild/bundler.js:3130:16)
    at Profile.run (/tools/runners/run-app.js:572:24)
    at Function.run (/root/.meteor/packages/meteor-tool/.1.8.3.g4mka5.pvict++os.linux.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.linux.x86_64/tools/tool-env/tools/tool-env/profile.ts:289:14)
    at bundleApp (/tools/runners/run-app.js:571:34)
    at AppRunner._runOnce (/tools/runners/run-app.js:613:35)
    at AppRunner._fiber (/tools/runners/run-app.js:929:28)
    at /tools/runners/run-app.js:401:12
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! Rocket.Chat@2.5.0-develop start: `meteor`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the Rocket.Chat@2.5.0-develop start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Will try to find the problem.

fdellwing · 2020-01-23T13:03:09Z

Got it to run (it takes over 5gb of RAM, that was the problem).

Sadly RC still does not work and there are two errors in devtools:

Error: Cannot find module 'meteor/mizzao:autocomplete' modules-runtime.js:232:12
There is no route for the path: / kadira_flow-router.js:517:13
uncaught exception: undefined

The page stays grey with the loading bubbles.

Running the develop branch from RocketChat/Rocket.Chat works fine.

I ran meteor add mizzao:autocomplete and now get another error:

Error: There are multiple templates named 'inputAutocomplete'. Each template needs a unique name. templating-runtime.js:55:13
There is no route for the path: / kadira_flow-router.js:517:13
uncaught exception: undefined

maciek134 · 2020-01-23T14:21:22Z

@fdellwing weird, I didn't add any dependencies and the autocomplete module was already used in RC. Maybe try rm -rf node_modules and meteor npm install?

fdellwing · 2020-01-23T14:28:09Z

Doing grep -r 'meteor/mizzao:autocomplete' on the develop branch shows no result. But you import it in line 6 of app/ui/client/components/userAutocomplete.js.

maciek134 · 2020-01-23T17:43:06Z

@fdellwing I see it now, PR #15956 released in 2.4.0 on 2019-12-27 removed this library, I guess a simple pull --rebase isn't going to be enough, I'll have to look through the codebase again, a lot has changed since I started working on this.

fdellwing · 2020-01-24T07:30:53Z

[08:29 root@FADE-Test Rocket.Chat] (feat/group-notifications[**]) > git diff
      1 diff --git a/app/ui/client/components/userAutocomplete.js b/app/ui/client/components/userAutocomplete.js
      2 index b4ca24077..97f0b9180 100644
      3 --- a/app/ui/client/components/userAutocomplete.js
      4 +++ b/app/ui/client/components/userAutocomplete.js
      5 @@ -3,7 +3,7 @@ import { ReactiveVar } from 'meteor/reactive-var';
      6  import { Blaze } from 'meteor/blaze';
      7  import { Session } from 'meteor/session';
      8  import { Template } from 'meteor/templating';
      9 -import { AutoComplete } from 'meteor/mizzao:autocomplete';
     10 +import { AutoComplete } from '../../../meteor-autocomplete/client';
     11  import { Deps } from 'meteor/deps';
     12  
     13  import './userAutocomplete.html';

Seems to work atm, no idea if it breaks something further down the line.

Edit: Found something not working with this autocomplete. Every autocomplete now searches the users instead of roles, groups or channel.

maciek134 · 2020-01-24T08:56:56Z

Oh yeah, that's not going to work, the new autocomplete uses REST, while the old one used subscriptions. I'll try to push a fix in the evening, along with linting and proper tests.

fdellwing · 2020-01-29T14:48:23Z

Any news on this?

maciek134 · 2020-02-11T10:52:49Z

Sorry, I've been on a vacation. I'll push the fixes today.

EDIT: pushed fixes, now it should work. I've also added missing translations and fixed linting. I'll add missing tests and users assigning themselves tomorrow.

Don't mind the commit message, it will be rebased.

fdellwing · 2020-02-13T09:44:55Z

Sadly, this happens:

uncaught exception: Error: Match error: Match error: Expected string, got function match.js:42:4
    check match.js:42
    on client.js:152
    onAll Notifications.js:62
    Notifications Notifications.js:21
    module Notifications.js:99
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module CachedCollection.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module index.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module index.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module settings.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module index.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    require modules-runtime.js:268
    module index.js:4
    module app.js:79867
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module common.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module index.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module importPackages.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    moduleLink modules.js:389
    module main.js:1
    fileEvaluate modules-runtime.js:346
    require modules-runtime.js:248
    require modules-runtime.js:268
    <anonym> app.js:95818

And the app goes in endless grey window mode.

ag0r4n · 2020-02-13T09:58:17Z

Will it be possible to notify all members of another channel ?

maciek134 · 2020-02-13T16:38:48Z

@fdellwing investigating
@ag0r4n not right now, I didn't implement that as this didn't come up in the linked issue. When the PR is out of WIP I guess core developers can decide if this should go here (my thinking would be to have this separate, so you just type #channelName and it notifies)

fdellwing · 2020-02-21T12:21:06Z

@maciek134 Any news?

maciek134 · 2020-02-27T17:36:33Z

I'll take another stab at it over the weekend, had no time the last couple of weeks.

joshua0623 · 2020-03-30T16:08:40Z

Hey @maciek134, are there any updates? This is a much needed feature for us, thank you for working on it!

maciek134 · 2020-04-04T18:34:10Z

@joshua0623 sorry, I've been focusing on the whole COVID-19 thing. Once I complete the current crunch I'll get back to this as I understand effective communication is vital these days.

danel1 · 2020-06-03T09:51:26Z

Any news here? :-)

maciek134 · 2020-06-04T09:19:21Z

@danel1 I'm in the process if finishing this up, started last weekend but didn't manage to finish yet, hopefully will have it ready this week.

fdellwing · 2020-06-26T11:40:00Z

Any news?

maciek134 · 2020-07-16T15:41:20Z

@fdellwing shouldn't have waited so long, it's a pain to update now, I'm slowly getting it to work.

danel1 · 2020-08-20T10:25:08Z

@rodrigok @maciek134 Sorry but this is really getting annoying. This feature has been requested by sooo many people in so many PR's/FR's and it just gets completely ignored by the dev-team?

maciek134 · 2020-08-20T19:50:06Z

@danel1 I'm not a part of the dev team, I'm just a guy providing his spare time. If you mean the PR getting ignored - it's not, because it's a draft, because it's not ready to be merged yet. It needs the 1k+ commits from develop merged back, which I'm working on (edit: this part is done, all I need to do now is finish the admin pages).

sviat9440 · 2020-08-26T13:59:14Z

How run rocketchat on this branch?

There is no packages/rocketchat-livechat/.npm/plugin/Livechat-new-11d3d3v.74ky

maciek134 · 2020-08-26T15:11:25Z

@sviat9440 I didn't push the fixes because they are not complete yet, hence the WIP status. Although this error looks like it's caused by a wrong setup. Either way I'm finishing the admin templates now, I'll try to push before Friday.

sviat9440 · 2020-08-26T16:11:01Z

I also think this is due to a misconfiguration.
But I did everything according to this instruction

runiq · 2020-08-31T09:34:45Z

Nothing to add, I just want to thank @maciek134 for their tireless support on this. <3

maciek134 · 2020-09-01T20:49:37Z

@runiq thanks :)
Progress update: fixed admin side of things for group listing / creation. Next up: users dropdown and editing.

fdellwing · 2020-10-09T08:44:44Z

@maciek134 How is it going?

maciek134 · 2020-10-09T15:15:25Z

I'll try to push it over the weekend, only small stuff left.

danel1 · 2020-10-19T09:01:33Z

I'll try to push it over the weekend, only small stuff left.

any news on this @maciek134 ?

sviat9440 · 2020-12-02T09:15:59Z

Any news?))

maciek134 · 2021-01-15T15:37:57Z

Got hit with so much overtime I don't remember most of what happened in the last months of 2020. I fixed the admin side of things (again) and I'm hoping to move this out of WIP this weekend. 🤞

fdellwing · 2021-02-16T10:09:08Z

Any progress?

sviat9440 · 2021-02-24T15:09:32Z

@maciek134 :)

Schoaf · 2021-03-31T11:19:10Z

OMG - is it really comming??

fdellwing · 2021-04-23T05:09:35Z

Sadly I do not think this will come. RC now has its teams feature that allows mentioning groups but they put it behind the EE license.

sviat9440 · 2021-04-23T05:19:31Z

@fdellwing Can you tell us more?

fdellwing · 2021-04-23T05:21:04Z

#20966

sviat9440 · 2021-04-23T05:25:54Z

@fdellwing what is EE?

fdellwing · 2021-04-23T05:27:14Z

https://rocket.chat/de/pricing/

Their Enterprise Edition.

sviat9440 · 2021-04-23T05:40:06Z

@fdellwing Is it possible to enable this on Rocket Chat Server?

fdellwing · 2021-04-23T05:41:12Z

Well, if you buy the license? Sure.

maciek134 · 2021-04-25T20:22:33Z

Uh, everyone who was waiting for this - sorry it took so long it got implemented in EE first. Once my company stopped using RC I didn't have enough time to work on this and what time I could spare wasn't even enough to keep up with upstream changes. To be fair the Teams feature looks much better than this.

Given that the Teams mentions are EE only I don't think this can even be merged anymore? @rodrigok you were assigned to this at some point, let me know if this is worth working on - at this point I'd just take a few days off to finish it.

CLAassistant · 2021-12-17T21:52:34Z

All committers have signed the CLA.

maciek134 force-pushed the feat/group-notifications branch from f155cbc to 85b9672 Compare January 22, 2020 22:31

maciek134 force-pushed the feat/group-notifications branch from 85b9672 to 7c8b85c Compare February 11, 2020 22:25

WIP: custom mention groups

100aa74

Don't mind the commit message, it will be rebased.

maciek134 force-pushed the feat/group-notifications branch from 7c8b85c to 100aa74 Compare February 11, 2020 22:30

ag0r4n mentioned this pull request Feb 17, 2020

All channel members notification RocketChat/feature-requests#288

Open

rodrigok mentioned this pull request May 30, 2020

[WIP]Custom group notifs #13569

Closed

rodrigok self-assigned this May 30, 2020

fdellwing mentioned this pull request Aug 2, 2021

Make team mentioning available without enterprise license RocketChat/feature-requests#491

Open

fdellwing mentioned this pull request Mar 22, 2022

Notifications - Implementing custom group notifications RocketChat/feature-requests#634

Open

ggazzo added the Invalid PR Title label Mar 30, 2023

ulope mentioned this pull request Apr 12, 2023

"Users must use Two Factor Authentication" setting does not work #27592

Open

[NEW] WIP: custom mention groups #16311

Are you sure you want to change the base?

[NEW] WIP: custom mention groups #16311

Conversation

maciek134 commented Jan 22, 2020 • edited Loading

WIP:

lgtm-com bot commented Jan 22, 2020

fdellwing commented Jan 23, 2020

fdellwing commented Jan 23, 2020 • edited Loading

maciek134 commented Jan 23, 2020

fdellwing commented Jan 23, 2020

maciek134 commented Jan 23, 2020 • edited Loading

fdellwing commented Jan 24, 2020 • edited Loading

maciek134 commented Jan 24, 2020

fdellwing commented Jan 29, 2020

maciek134 commented Feb 11, 2020 • edited Loading

fdellwing commented Feb 13, 2020 • edited Loading

ag0r4n commented Feb 13, 2020

maciek134 commented Feb 13, 2020

fdellwing commented Feb 21, 2020

maciek134 commented Feb 27, 2020

joshua0623 commented Mar 30, 2020

maciek134 commented Apr 4, 2020

danel1 commented Jun 3, 2020

maciek134 commented Jun 4, 2020

fdellwing commented Jun 26, 2020

maciek134 commented Jul 16, 2020

danel1 commented Aug 20, 2020

maciek134 commented Aug 20, 2020 • edited Loading

sviat9440 commented Aug 26, 2020

maciek134 commented Aug 26, 2020

sviat9440 commented Aug 26, 2020

runiq commented Aug 31, 2020

maciek134 commented Sep 1, 2020

fdellwing commented Oct 9, 2020

maciek134 commented Oct 9, 2020

danel1 commented Oct 19, 2020

sviat9440 commented Dec 2, 2020

maciek134 commented Jan 15, 2021

fdellwing commented Feb 16, 2021

sviat9440 commented Feb 24, 2021

Schoaf commented Mar 31, 2021

fdellwing commented Apr 23, 2021

sviat9440 commented Apr 23, 2021

fdellwing commented Apr 23, 2021

sviat9440 commented Apr 23, 2021

fdellwing commented Apr 23, 2021

sviat9440 commented Apr 23, 2021

fdellwing commented Apr 23, 2021

maciek134 commented Apr 25, 2021

CLAassistant commented Dec 17, 2021 • edited Loading

maciek134 commented Jan 22, 2020 •

edited

Loading

fdellwing commented Jan 23, 2020 •

edited

Loading

maciek134 commented Jan 23, 2020 •

edited

Loading

fdellwing commented Jan 24, 2020 •

edited

Loading

maciek134 commented Feb 11, 2020 •

edited

Loading

fdellwing commented Feb 13, 2020 •

edited

Loading

maciek134 commented Aug 20, 2020 •

edited

Loading

CLAassistant commented Dec 17, 2021 •

edited

Loading