Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] avoid send presence without login #11074

Merged
merged 1 commit into from
Jun 10, 2018
Merged

[FIX] avoid send presence without login #11074

merged 1 commit into from
Jun 10, 2018
+35 −40

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 10, 2018 •
edited by sampaiodiego
Loading

We realized we are sending user presence even before the user get logged in.

@ggazzo ggazzo requested review from rodrigok and sampaiodiego June 10, 2018 01:41
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11074 June 10, 2018 01:48 Abandoned
@ggazzo ggazzo requested a deployment to rocket-chat-pr-11074 June 10, 2018 02:10 Abandoned
@engelgabriel engelgabriel merged commit 8d14522 into develop Jun 10, 2018
@engelgabriel engelgabriel deleted the avoid-presence branch June 10, 2018 02:12
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @engelgabriel