Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Link previews not being removed from messages after removed on editing #11063

Merged
merged 1 commit into from
Jun 10, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 8, 2018

Now its working properly

When I edit my sent message and remove a link from it, the link preview stays in the chat.
Mac App Version 1.3.1 (15)

Closes #2833

@sampaiodiego sampaiodiego changed the title [FIX] updateMessage to remove links (if they were removed) [FIX] Link previews not being removed from messages after removed on editing Jun 10, 2018
@sampaiodiego sampaiodiego merged commit f539f66 into develop Jun 10, 2018
@sampaiodiego sampaiodiego deleted the remove-preview-link-update-message branch June 10, 2018 14:40
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request Jun 11, 2018
* develop: (215 commits)
  [FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically (RocketChat#9959)
  [FIX] Notification not working for group mentions and not respecting ignored users (RocketChat#11024)
  fixed searchbar icon and text overlap (RocketChat#10294)
  [FIX] Link previews not being removed from messages after removed on editing (RocketChat#11063)
  avoid send presence without loggin
  Fix: Exception in metrics generation
  Update release template
  Update issue templates
  Update pt-BR.i18n.json
  LingoHub Update 🚀
  update import capnp
  update build for Sandstorm, add dependence capnp.
  LingoHub Update 🚀
  Fixing HTML on translation files
  Fixing HTML on translation files
  LingoHub Update 🚀
  Fixing HTML on translation files
  Fixing HTML on translation files
  Fixing HTML on translation files
  LingoHub Update 🚀
  ...

# Conflicts:
#	.meteor/packages
#	README.md
#	client/startup/startup.js
#	package-lock.json
#	packages/rocketchat-error-handler/server/lib/RocketChat.ErrorHandler.js
#	packages/rocketchat-i18n/i18n/en.i18n.json
#	packages/rocketchat-i18n/i18n/vi-VN.i18n.json
#	packages/rocketchat-livechat/config.js
#	server/startup/initialData.js
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request Jun 11, 2018
* goalify: (217 commits)
  Add more scripts to reduce mannual interaction during server init
  [FIX] Rooms list sorting by activity multiple re-renders and case sensitive sorting alphabetically (RocketChat#9959)
  [FIX] Notification not working for group mentions and not respecting ignored users (RocketChat#11024)
  fixed searchbar icon and text overlap (RocketChat#10294)
  [FIX] Link previews not being removed from messages after removed on editing (RocketChat#11063)
  avoid send presence without loggin
  Fix: Exception in metrics generation
  Update release template
  Update issue templates
  Update pt-BR.i18n.json
  LingoHub Update 🚀
  update import capnp
  update build for Sandstorm, add dependence capnp.
  LingoHub Update 🚀
  Fixing HTML on translation files
  Fixing HTML on translation files
  LingoHub Update 🚀
  Fixing HTML on translation files
  Fixing HTML on translation files
  Fixing HTML on translation files
  ...
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link previews are not removed when the link is edited out
3 participants