chore: deprecate from field from Email Bridge (#33713)

Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>

.changeset/forty-gorillas-kneel.md

@@ -0,0 +1,6 @@
+---
+"@rocket.chat/meteor": patch
+"@rocket.chat/apps-engine": patch
+---
+
+Deprecated the `from` field in the apps email bridge and made it optional, using the server's settings when the field is omitted

apps/meteor/app/apps/server/bridges/email.ts

@@ -3,14 +3,21 @@ import type { IEmail } from '@rocket.chat/apps-engine/definition/email';
 import { EmailBridge } from '@rocket.chat/apps-engine/server/bridges';
 
 import * as Mailer from '../../../mailer/server/api';
+import { settings } from '../../../settings/server';
 
 export class AppEmailBridge extends EmailBridge {
 	constructor(private readonly orch: IAppServerOrchestrator) {
 		super();
 	}
 
 	protected async sendEmail(email: IEmail, appId: string): Promise<void> {
+		let { from } = email;
+		if (!from) {
+			this.orch.debugLog(`The app ${appId} didn't provide a from address, using the default one.`);
+			from = String(settings.get('From_Email'));
+		}
+
 		this.orch.debugLog(`The app ${appId} is sending an email.`);
-		await Mailer.send(email);
+		await Mailer.send({ ...email, from });
 	}
 }

packages/apps-engine/src/definition/email/IEmail.ts

@@ -1,6 +1,9 @@
 export interface IEmail {
     to: string | string[];
-    from: string;
+    /**
+     * @deprecated this will be inferred from the settings
+     */
+    from?: string;
     replyTo?: string;
     subject: string;
     html?: string;