Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image viewer loosing quality #5878

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 23, 2024

Proposed changes

It seems to be an issue on RN's Image component, since it works fine on react-native-fast-image. It could be a regression from #5621

Issue(s)

How to test or reproduce

  • Image viewer from AttachmentView
  • Image viewer inside share extension

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

SUP-671

@diegolmello diegolmello marked this pull request as ready for review September 23, 2024 14:30
@OtavioStasiak
Copy link
Contributor

Tested on Android and iOS

I’ve tested the implementation on both Android and iOS platforms, and everything functions as expected.

Platforms Tested:

Android (Pixel 6 API 35)
iOS (iPhone 15 iOS 17.5)

Results:

No platform-specific issues encountered and the issue has been solved.

Code Review

The code has been reviewed for correctness, readability, and it works as expected.

Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS
I’ve tested the implementation on both Android and iOS platforms, and everything functions as expected.

Platforms Tested:
Android (Pixel 6 API 35)
iOS (iPhone 15 iOS 17.5)

Results:
No platform-specific issues encountered and the issue has been solved.

Code Review
The code has been reviewed for correctness, readability, and it works as expected.

@diegolmello diegolmello merged commit bc35b09 into develop Sep 24, 2024
3 of 5 checks passed
@diegolmello diegolmello deleted the fix.image-preview-quality branch September 24, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants