Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Help page #5855

Merged
merged 14 commits into from
Sep 24, 2024
Merged

feat: Help page #5855

merged 14 commits into from
Sep 24, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Sep 4, 2024 •
edited by jira bot
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

MA-71

@yash-rajpal yash-rajpal marked this pull request as ready for review September 4, 2024 15:44
diegolmello
diegolmello requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing E2E tests

app/views/SettingsView/index.tsx Outdated Show resolved Hide resolved
app/views/GetHelpView.tsx Outdated Show resolved Hide resolved
app/i18n/locales/en.json Show resolved Hide resolved
diegolmello
diegolmello requested changes Sep 16, 2024
View reviewed changes
app/views/SettingsView/index.tsx Outdated Show resolved Hide resolved
e2e/tests/assorted/04-setting.spec.ts Outdated Show resolved Hide resolved
@diegolmello diegolmello merged commit 19f0288 into develop Sep 24, 2024
2 of 4 checks passed
@diegolmello diegolmello deleted the help-page branch September 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-rajpal @diegolmello