Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty draft when the message is sent #5595

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Feb 26, 2024

Proposed changes

Currently, after sending the message, if you close the app abruptly the draft is not deleted, adding the function to save the draft after sending the message solves the problem.

Issue(s)

How to test or reproduce

  • Send a message and close the app quickly, the draft should be removed.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-116

@dnlsilva dnlsilva changed the title fix: set draft when the message is sent fix: empty draft when the message is sent Feb 26, 2024
@dnlsilva dnlsilva marked this pull request as ready for review February 26, 2024 17:47
@dnlsilva dnlsilva merged commit 54f2cea into develop Feb 28, 2024
4 of 9 checks passed
@dnlsilva dnlsilva deleted the fix-draft-message branch February 28, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants