[NEW] Adds drag-and-drop on sidebar #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it allows you to reorder it and then saves it using localstorage
gdelavald
reviewed
Sep 13, 2017
| localStorage.setItem(this.sortOrderKey, JSON.stringify(this.sortOrder)); | ||
|
|
||
| const url = sideBarElement.dataset.host; | ||
| const host = { url, title: sideBarElement.querySelector('div.tooltip').innerHTML }; |
There was a problem hiding this comment.
We should add the active class to the selected server as well.
There was a problem hiding this comment.
done! it should be after recreating the servers on the sidebar, so I put it on the end of the drop listener
gdelavald
reviewed
Sep 13, 2017
src/scripts/sidebar.js
Outdated
| }); | ||
| Object.values(servers.hosts) | ||
| .sort((a, b) => { | ||
| const orderA = this.sortOrder.indexOf(a.url); |
There was a problem hiding this comment.
No need for consts here IMO, just return the values.
|
@vcapretz can you post a gif showing the feature? |
|
@rodrigok added on the the first comment! |
when dropping the dragged server on the final position it should be set as the active one
gdelavald
pushed a commit
that referenced
this pull request
Oct 27, 2017
* Adds drag-and-drop on sidebar it allows you to reorder it and then saves it using localstorage * Set active to the dragged server when dropping the dragged server on the final position it should be set as the active one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/DesktopApp
Closes #214
this feature introduce the option to drag and drop servers on sidebar, it uses localstorage to save it so when you open the app again it should keep the order