Add shortcuts inside webview to move back/forward #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should get ctrl or cmd keys to go back and forward on history inside the channels
|
|
alexbrazier
suggested changes
Sep 8, 2017
src/scripts/webview.js
Outdated
| @@ -41,6 +42,24 @@ class WebView extends EventEmitter { | |||
| }, '*') | |||
| `); | |||
| }); | |||
|
|
|||
| Mousetrap.bind(['command+left', 'ctrl+left'], () => { | |||
There was a problem hiding this comment.
Looks like you should use "mod+left" instead for cross platform, rather than binding both.
src/scripts/webview.js
Outdated
| Mousetrap.bind(['command+left', 'ctrl+left'], () => { | ||
| const webviewObj = this.getActive(); | ||
| webviewObj.executeJavaScript(` | ||
| window.history.back(); |
There was a problem hiding this comment.
Does the built in electron method not work here?
we are now using menu items and accelerators for binding shortcuts the shortcuts on windows and linux should be "alt+left/right" and on mac "cmd+left/right", like on chrome for instance
alexbrazier
approved these changes
Sep 11, 2017
gdelavald
pushed a commit
that referenced
this pull request
Oct 27, 2017
* first attempt * Adds mousetrap as a dependency it should get ctrl or cmd keys to go back and forward on history inside the channels * Fix multiple spaceslint error * Removes mousetrap dependency we are now using menu items and accelerators for binding shortcuts the shortcuts on windows and linux should be "alt+left/right" and on mac "cmd+left/right", like on chrome for instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/DesktopApp
Closes #197
Mousetrap is a package to help we configure shortcuts, now when you are inside a channel and type Ctrl (or Cmd) + Left/Right it acts just like the browser, so you can switch between channels.