Only show reload screen if main webview error #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this hit if the server returns 502? Like in case of demo server. Some times it'll be restarting and return 502 Gateway error. Will this show then too? |
|
@geekgonecrazy Good spot. I have just updated it so it catches 50x errors, and tested it for 502 errors. |
|
👍 awesome! This looks like a very useful UX thing to me! |
rodrigok
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #385
Closes #389
It seems the
did-fail-loadevent fires when links such as youtube fail to load, causing the server reload screen to show. This makes it only check for errors in loading the main app.