Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix for basic-auth servers connect #1074

Merged
merged 1 commit into from
Feb 14, 2019
Merged

[FIX] Fix for basic-auth servers connect #1074

merged 1 commit into from
Feb 14, 2019

Conversation

Drintios
Copy link
Contributor

@Drintios Drintios commented Feb 4, 2019

@RocketChat/electron

Closes #1073

Fixes issue described on issue 1073 by extracting credentials and adding them as headers to the api/info request under server.validateHost function

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tassoevan tassoevan self-requested a review February 6, 2019 01:48
tassoevan
tassoevan requested changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! I just want to ask you to run yarn lint --fix to apply small linter corrections, like use const instead of let.

@tassoevan tassoevan added this to the 2.15.0 milestone Feb 6, 2019
@Drintios
Copy link
Contributor Author

Drintios commented Feb 6, 2019

@tassoevan pushed fix, thanks for the feedback 😄

@tassoevan tassoevan merged commit 0369fea into RocketChat:develop Feb 14, 2019
engelgabriel added a commit that referenced this pull request Feb 23, 2019
@engelgabriel
Merge branch 'develop'
0280405 
* develop: (51 commits)
  [FIX] Use Electron notifications (#1101)
  [FIX] Updates preloads scripts to be compatible with Rocket.Chat >0.74.0 (#1099)
  Update gulp
  Update dependencies
  [IMPROVE] i18next (#1096)
  [IMPROVE] New tray icons (#1093)
  [CHORE] Remove unused styles (#1092)
  [IMPROVE] Remove update-remind-later-dialog (#1076)
  Fix for basic-auth servers connect (#1074)
  Fix remember window state on load (#1080)
  Update provisioning profile
  Disable artifact collection by AppVeyor (#1081)
  Add workaround for webview readiness
  update dependencies electron => 4.0.1
  [improve] resolve requested changes
  Replace istanbul with nyc
  Work around icon window in e2e tests
  Add missing id in menu item
  Enable tests in CI
  Fix e2e tests
  ...
@andypost andypost deleted the closes_1073_basic-auth branch February 27, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
feat: sidebar / servers list type: bug
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Drintios @CLAassistant @tassoevan