-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: inappchat component for virtual conference #78
Conversation
145378c
to
c9b9cc0
Compare
Fetching Messages And Sending Messagesrocketchatcomponent2.mp4 |
This pull request introduces 1 alert when merging c9b9cc0 into 1386a00 - view on LGTM.com new alerts:
|
…/RC4Community into rocketchatcomponent
This pull request introduces 1 alert and fixes 1 when merging 203361d into 1386a00 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review comments.
@@ -9,6 +9,10 @@ | |||
"lint": "next lint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can move these down to the componenet level -- making each one of our components an indepdendently installable npm module (optionally).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can achieve this by making a monorepo and optionally dealing with components as we need. I will talk with Rohan sir about this and let you know
This is terrible UX fwiw. When there is no chat - we want the video to be in "full size" maxed out on the frame without sacrificing aspect. The "tab" or "button" or "arrow" to activate chat should be up at the top right - as small as reasonable -- and be transparent if placed over the playing video. On mobile, there should be no "tab"/"button"/"arrow" at all, but just a "swipe right" gesture. Please confer with irfan on the "design" for next iteration. |
True, I've just placed them as placeholders for now.Will be working on them soon |
This pull request introduces 2 alerts and fixes 1 when merging 691ad32 into 3927e64 - view on LGTM.com new alerts:
fixed alerts:
|
@sidmohanty11 does the current code include the emoji support you have shown us today? I'd like to marge it down ASAP so @demonicirfan can add the animations. Let me know. It would be good if the cookie implementation can be added as well (but not necessarily at this time). |
Just give me one more day so I can try my best to figure out if we can use the cookies and clean some things up Thank you! |
This pull request fixes 1 alert when merging 4b79c36 into 3927e64 - view on LGTM.com fixed alerts:
|
@Sing-Li , I have added the cookies part here (full-validation from browser cookies) rc4_inappchat1.mp4But we are facing a major roadblock, i.e, with the previous approach (with CSR approach) after a certain interval the requests are being revalidated which as I have discussed with Rohan sir and he agreed that that might not be the best approach. So it is still to be figured out. :( |
Cool. @sidmohanty11 Let's go with the current way of handling (hard coded ENVIRONMENT VAR) for now. Is it OK for me to merge this down now? |
@Sing-Li I can work on that on a separate PR, and as UI needs a lot of work I think @demonicirfan can take it from here |
rocketchatcomponent1.mp4
#38