Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Option to read firebase service account from file #63

Merged
merged 24 commits into from
Jan 30, 2022

Conversation

abhinavkrin
Copy link
Member

Set GOOGLE_CREDS_PATH to the path of the service account JSON file downloaded from the firebase console. The initAuth function would read projectId, clientEmail and privateKey from json file instead of FIREBASE_PROJECT_ID, FIREBASE_CLIENT_EMAIL, FIREBASE_PRIVATE_KEY environment vars.

@debdutdeb debdutdeb changed the title [ADDED]: Option to read firebase service account from file [NEW] Option to read firebase service account from file Jan 29, 2022
@debdutdeb
Copy link
Member

Forcing workflow run.

@debdutdeb debdutdeb closed this Jan 29, 2022
@debdutdeb debdutdeb reopened this Jan 29, 2022
Copy link
Collaborator

@RonLek RonLek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RonLek RonLek merged commit 458f0ed into RocketChat:master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants