Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed] Responsiveness of Latest Community News Section #209

Merged
merged 4 commits into from
Jan 3, 2023
Merged

[Fixed] Responsiveness of Latest Community News Section #209

merged 4 commits into from
Jan 3, 2023

Conversation

itsmanojthapa
Copy link
Contributor

@itsmanojthapa itsmanojthapa commented Dec 5, 2022 •
edited by gitpod-io bot
Loading

Solved #205

Before:
image

After:
image

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Dec 5, 2022

@Palanikannan1437
Copy link
Contributor

Hey @itsmanojthapa, awesome work there...thanks a ton for keeping the design and making it responsive at the same time!

Could you please fix the mismatched heights of the items while you're at it? Thank you 😄

image

@itsmanojthapa
Copy link
Contributor Author

itsmanojthapa commented Dec 5, 2022 •
edited
Loading

Is this fine @Palanikannan1437

pic 1:
image

pic: 2:
image

pic 3:
image

pic 4:
image

@Palanikannan1437
Copy link
Contributor

LGTM @itsmanojthapa!!, thanks for your PR!

@Sing-Li it's ready to be merged, thank you!

@Sing-Li Sing-Li merged commit 549d4a7 into RocketChat:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dnouv Dnouv Dnouv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itsmanojthapa @CLAassistant @Palanikannan1437 @Dnouv @Sing-Li