FIX : Cleaned up components by parameterising #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dnouv please let me know if further components are to be parameterised and if I've missed out on something. I'm a bit confused if we want anything else to be parameterised 😅 (I haven't gone through Jitsi related components yet, will do that asap) Thank you! |
|
Thank you for the hard work! Yes, this is all good till now; great work! |
Ohh yeah I did go through the forms, they already seemed parameterized😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195
Issue in brief
Some components weren't fully parameterised to be used as customisable components in pages
Suggested Fixes/Changes