Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Create Notion Page From RocketChat #20

Merged
merged 12 commits into from
Aug 20, 2023
Merged

[Feat] Create Notion Page From RocketChat #20

merged 12 commits into from
Aug 20, 2023

Conversation

Nabhag8848
Copy link
Collaborator

@Nabhag8848 Nabhag8848 commented Jul 13, 2023 •
edited
Loading

Issue(s)

Acceptance Criteria fulfillment

  • Register /notion create command
  • Create SearchPagesAndDatabases and CreatePage Method in NotionSDK
  • Create Reusable method for SearchPageAndDatabaseComponent and getSelectDatabaseLayout
  • Have Two Options in OverFlow Menu CreateDatabase and Change Database(Only when Database is selected)
  • Handle creation of SubPage in specific page, and Update the Modal when there is selection Of Database.

Proposed changes (including videos or screenshots)

DEMO

Further comments

@Nabhag8848 Nabhag8848 marked this pull request as ready for review July 13, 2023 07:10
@Nabhag8848 Nabhag8848 mentioned this pull request Jul 13, 2023
Closed
5 tasks
@Nabhag8848
feat: register create command param for create-record-page
c3e0370
@Nabhag8848
feat: created searchPagesAndDatabases() in NotionSDK
9b33b91
@Nabhag8848
feat: created searchPageOrDatabaseComponent()
4c55c00
@Nabhag8848
feat: created selected Database Preview Layout Component
cb946aa
@Nabhag8848
feat: created CreatedPageOrRecordModal()
afee81a 
description: currently this contains just the implementation of creation of page and doesn't include the complete implementation when database selected
@Nabhag8848
feat: implemented createNotionPageOrRecord(update?:boolean)
e3ed2c3
@Nabhag8848
refactor(comment): calling action of handleRefreshCommentAction()
a18fd04
@Nabhag8848
feat(ui): handleSearchPageAndDB Action to Update Modal Accordingly
03a3a99
@Nabhag8848
feat: handledOverFlowMenuAction of Create Database and Change Database
bef6a83
@Nabhag8848
fix: clearPagesOrDatabases() onClose of Modal
04c45a7
@Nabhag8848
feat: created createPage() in NotionSDK
11991b5
@Nabhag8848
feat: handledCreationOfPage without viewErrors
5899266 
description: handleCreationOfRecord is not implemented which will be done in addup PR but note that this doesnt contain viewErrors as well,see you soon
@Nabhag8848 Nabhag8848 force-pushed the feat/create-record-page branch from d4e077a to 5899266 Compare August 20, 2023 07:31
samad-yar-khan
samad-yar-khan approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Nabhag8848

@samad-yar-khan samad-yar-khan merged commit 3fd6031 into RocketChat:main Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samad-yar-khan samad-yar-khan samad-yar-khan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nabhag8848 @samad-yar-khan