Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Replace tslint with eslint and improve typing of app #72

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Chore: Replace tslint with eslint and improve typing of app #72

merged 6 commits into from
Dec 1, 2021

Conversation

KevLehman
Copy link
Contributor

  • Replace TSLint (since it's deprecated)
  • Added ESLint support for app
  • Added Prettier support for app
  • Fixed ESLint warnings due to use of and added new type declarations

@murtaza98
Copy link
Contributor

Hi, @KevLehman There are a couple of conflicts introduced here due to recent merges...Could you please take a look at them?

@KevLehman
Copy link
Contributor Author

Updated. Please check that my resolutions are the right ones 👀

murtaza98
murtaza98 reviewed Nov 30, 2021
View reviewed changes
DialogflowApp.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 reviewed Nov 30, 2021
View reviewed changes
DialogflowApp.ts Outdated Show resolved Hide resolved
KevLehman and others added 2 commits November 30, 2021 11:08
@KevLehman
add gh step to typecheck before packaging app
c64b658
@murtaza98
Refactoring
df9685b 
- Fix unused variable issues
- Avoid using console.error(e)
@murtaza98
Copy link
Contributor

Hey, @KevLehman I've included my suggestions within this PR - #73. Please review and merge them here when you get a chance 😄

Thanks for this initiative 💙

@murtaza98 murtaza98 merged commit d0d4dee into master Dec 1, 2021
@murtaza98 murtaza98 deleted the chore/replace-tslint branch December 1, 2021 09:39
@Shailesh351 Shailesh351 mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtaza98 murtaza98 murtaza98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevLehman @murtaza98