Merge pull request #73 from RocketChat/chore/replace-tslint-1

RocketChat · Nov 30, 2021 · 5bb3e22 · 5bb3e22
2 parents c64b658 + df9685b
commit 5bb3e22
Show file tree

Hide file tree

Showing 10 changed files with 35 additions and 60 deletions.
diff --git a/DialogflowApp.ts b/DialogflowApp.ts
@@ -40,16 +40,14 @@ export class DialogflowApp
 	public async executeLivechatBlockActionHandler(
 		context: UIKitLivechatBlockInteractionContext,
 		read: IRead,
-		http: IHttp,
-		persistence: IPersistence,
+		_http: IHttp,
+		_persistence: IPersistence,
 		modify: IModify,
 	): Promise<IUIKitResponse> {
 		const handler = new ExecuteLivechatBlockActionHandler(
 			this,
 			context,
 			read,
-			http,
-			persistence,
 			modify,
 		);
 		return await handler.run();
@@ -59,23 +57,22 @@ export class DialogflowApp
 		message: ILivechatMessage,
 		read: IRead,
 		http: IHttp,
-		persis: IPersistence,
+		_persis: IPersistence,
 		modify: IModify,
 	): Promise<void> {
 		const handler = new PostMessageSentHandler(
 			this,
 			message,
 			read,
 			http,
-			persis,
 			modify,
 		);
 		await handler.run();
 	}
 
 	public async onSettingUpdated(
-		setting: ISetting,
-		configurationModify: IConfigurationModify,
+		_setting: ISetting,
+		_configurationModify: IConfigurationModify,
 		read: IRead,
 		http: IHttp,
 	): Promise<void> {

diff --git a/app.json b/app.json
@@ -1,16 +1,19 @@
 {
-	"id": "21b7d3ba-031b-41d9-8ff2-fbbfa081ae90",
-	"version": "1.2.4",
-	"requiredApiVersion": "^1.17.0",
-	"iconFile": "icon.png",
-	"author": {
-		"name": "Rocket.Chat",
-		"homepage": "https://rocket.chat/",
-		"support": "support@rocket.chat"
-	},
-	"name": "Dialogflow",
-	"nameSlug": "dialogflow",
-	"classFile": "DialogflowApp.ts",
-	"description": "Integration between Rocket.Chat and the Dialogflow Chatbot platform",
-	"implements": ["IPostMessageSent", "IUIKitLivechatInteractionHandler"]
-}
+    "id": "21b7d3ba-031b-41d9-8ff2-fbbfa081ae90",
+    "version": "1.2.4",
+    "requiredApiVersion": "^1.17.0",
+    "iconFile": "icon.png",
+    "author": {
+        "name": "Rocket.Chat",
+        "homepage": "https://rocket.chat/",
+        "support": "support@rocket.chat"
+    },
+    "name": "Dialogflow",
+    "nameSlug": "dialogflow",
+    "classFile": "DialogflowApp.ts",
+    "description": "Integration between Rocket.Chat and the Dialogflow Chatbot platform",
+    "implements": [
+        "IPostMessageSent",
+        "IUIKitLivechatInteractionHandler"
+    ]
+}
diff --git a/endpoints/FulfillmentsEndpoint.ts b/endpoints/FulfillmentsEndpoint.ts
@@ -1,8 +1,6 @@
 import {
 	HttpStatusCode,
-	IHttp,
 	IModify,
-	IPersistence,
 	IRead,
 } from '@rocket.chat/apps-engine/definition/accessors';
 import {
@@ -23,16 +21,14 @@ export class FulfillmentsEndpoint extends ApiEndpoint {
 
 	public async post(
 		request: IApiRequest,
-		endpoint: IApiEndpointInfo,
+		_endpoint: IApiEndpointInfo,
 		read: IRead,
 		modify: IModify,
-		http: IHttp,
-		persis: IPersistence,
 	): Promise<IApiResponse> {
 		this.app.getLogger().info(Logs.ENDPOINT_RECEIVED_REQUEST);
 
 		try {
-			await this.processRequest(read, modify, persis, request);
+			await this.processRequest(read, modify, request);
 			return createHttpResponse(
 				HttpStatusCode.OK,
 				{ 'Content-Type': Headers.CONTENT_TYPE_JSON },
@@ -53,7 +49,6 @@ export class FulfillmentsEndpoint extends ApiEndpoint {
 	private async processRequest(
 		read: IRead,
 		modify: IModify,
-		persis: IPersistence,
 		request: IApiRequest,
 	) {
 		const message: IDialogflowMessage = Dialogflow.parseRequest(

diff --git a/endpoints/IncomingEndpoint.ts b/endpoints/IncomingEndpoint.ts
@@ -28,11 +28,10 @@ export class IncomingEndpoint extends ApiEndpoint {
 
 	public async post(
 		request: IApiRequest,
-		endpoint: IApiEndpointInfo,
+		_endpoint: IApiEndpointInfo,
 		read: IRead,
 		modify: IModify,
 		http: IHttp,
-		// persis: IPersistence,
 	): Promise<IApiResponse> {
 		this.app.getLogger().info(Logs.ENDPOINT_RECEIVED_REQUEST);
 

diff --git a/handler/ExecuteLivechatBlockActionHandler.ts b/handler/ExecuteLivechatBlockActionHandler.ts
@@ -1,7 +1,5 @@
 import {
-	IHttp,
 	IModify,
-	IPersistence,
 	IRead,
 } from '@rocket.chat/apps-engine/definition/accessors';
 import { IApp } from '@rocket.chat/apps-engine/definition/IApp';
@@ -27,8 +25,6 @@ export class ExecuteLivechatBlockActionHandler {
 		private readonly app: IApp,
 		private context: UIKitLivechatBlockInteractionContext,
 		private read: IRead,
-		private http: IHttp,
-		private persistence: IPersistence,
 		private modify: IModify,
 	) {}
 

diff --git a/handler/OnSettingUpdatedHandler.ts b/handler/OnSettingUpdatedHandler.ts
@@ -37,7 +37,7 @@ export class OnSettingUpdatedHandler {
 			);
 			this.app.getLogger().info(Logs.GOOGLE_AUTH_SUCCESS);
 		} catch (error) {
-			this.app.getLogger().error(error.message);
+			this.app.getLogger().error(error);
 		}
 	}
 }
diff --git a/handler/PostMessageSentHandler.ts b/handler/PostMessageSentHandler.ts
@@ -1,7 +1,6 @@
 import {
 	IHttp,
 	IModify,
-	IPersistence,
 	IRead,
 } from '@rocket.chat/apps-engine/definition/accessors';
 import { IApp } from '@rocket.chat/apps-engine/definition/IApp';
@@ -31,7 +30,6 @@ export class PostMessageSentHandler {
 		private readonly message: ILivechatMessage,
 		private readonly read: IRead,
 		private readonly http: IHttp,
-		private readonly persis: IPersistence,
 		private readonly modify: IModify,
 	) {}
 

diff --git a/lib/Dialogflow.ts b/lib/Dialogflow.ts
@@ -43,12 +43,12 @@ class DialogflowClass {
 		);
 
 		const queryInput = {
-			...(requestType === DialogflowRequestType.EVENT && {
+			...requestType === DialogflowRequestType.EVENT && {
 				event: request,
-			}),
-			...(requestType === DialogflowRequestType.MESSAGE && {
+			},
+			...requestType === DialogflowRequestType.MESSAGE && {
 				text: { languageCode: LanguageCode.EN, text: request },
-			}),
+			},
 		};
 
 		const httpRequestContent: IHttpRequest = createHttpRequest(

diff --git a/lib/Message.ts b/lib/Message.ts
@@ -140,11 +140,7 @@ export const createMessage = async (
 		msg.addBlocks(blocks);
 	}
 
-	try {
-		return await modify.getCreator().finish(msg);
-	} catch (e) {
-		console.error(e);
-	}
+	return modify.getCreator().finish(msg);
 };
 
 export const createLivechatMessage = async (
@@ -190,11 +186,7 @@ export const createLivechatMessage = async (
 		msg.addAttachment(attachment);
 	}
 
-	try {
-		return await modify.getCreator().finish(msg);
-	} catch (e) {
-		console.error(e);
-	}
+	return modify.getCreator().finish(msg);
 };
 
 export const deleteAllActionBlocks = async (

diff --git a/lib/Room.ts b/lib/Room.ts
@@ -14,8 +14,7 @@ import { createMessage } from './Message';
 
 export const updateRoomCustomFields = async (
 	rid: string,
-	// eslint-disable-next-line
-	data: { [k: string]: any },
+	data: { [k: string]: unknown },
 	read: IRead,
 	modify: IModify,
 ): Promise<void> => {
@@ -45,11 +44,7 @@ export const updateRoomCustomFields = async (
 	const roomBuilder = await modify.getUpdater().room(rid, user);
 	roomBuilder.setCustomFields(customFields);
 
-	try {
-		await modify.getUpdater().finish(roomBuilder);
-	} catch (error) {
-		console.error(error);
-	}
+	return modify.getUpdater().finish(roomBuilder);
 };
 
 export const closeChat = async (modify: IModify, read: IRead, rid: string) => {