Issue 545/lingui translation wrappings #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue-545/lingui-translation-wrappings
… issue-545/lingui-translation-wrappings
Tyl13
commented
May 11, 2023
Tyl13
commented
May 11, 2023
Tyl13
commented
May 11, 2023
…ub.com/ulsdevteam/dimes into issue-545/lingui-translation-wrappings
|
This is looking really solid! I'm wondering if we need a README update to document/point to documentation on how to implement translations. |
Co-authored-by: Hillel Arnold <helrond@hotmail.com>
…ub.com/ulsdevteam/dimes into issue-545/lingui-translation-wrappings
|
Hopefully nothing was missed and it all looks good, but it should be good to merge. |
helrond
changed the title
HaSistrunk
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my current work that is done on adding Lingui Translation Wrappings. It includes changes to yarn.lock. New messages are extracted by running yarn extract and then they are compiled to Javascript with yarn compile. I have a few questions about certain sections but if you have anything that you want clarified first, or just more information on what is happening. Please ask. When this is finished, it will resolve #545. I believe there are some questions in the issue too that may provide additional information about Lingui.