Merge pull request ddnet#9131 from ChillerDragon/pr_fix_mysql_null_bind

Fix empty vector element access in mysql prepare
Robyt3 · Oct 9, 2024 · a9e52d2 · a9e52d2
2 parents 4dbf9a1 + f7955a5
commit a9e52d2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/engine/server/databases/mysql.cpp b/src/engine/server/databases/mysql.cpp
@@ -331,8 +331,11 @@ bool CMysqlConnection::PrepareStatement(const char *pStmt, char *pError, int Err
 	unsigned NumParameters = mysql_stmt_param_count(m_pStmt.get());
 	m_vStmtParameters.resize(NumParameters);
 	m_vStmtParameterExtras.resize(NumParameters);
-	mem_zero(&m_vStmtParameters[0], sizeof(m_vStmtParameters[0]) * m_vStmtParameters.size());
-	mem_zero(&m_vStmtParameterExtras[0], sizeof(m_vStmtParameterExtras[0]) * m_vStmtParameterExtras.size());
+	if(NumParameters)
+	{
+		mem_zero(&m_vStmtParameters[0], sizeof(m_vStmtParameters[0]) * m_vStmtParameters.size());
+		mem_zero(&m_vStmtParameterExtras[0], sizeof(m_vStmtParameterExtras[0]) * m_vStmtParameterExtras.size());
+	}
 	return false;
 }