Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible yes_no Property Detection #107

Closed
ec-m opened this issue Jun 19, 2019 · 3 comments
Closed

More flexible yes_no Property Detection #107

ec-m opened this issue Jun 19, 2019 · 3 comments
Assignees
@emlozin
Labels
inference 💡
Milestone
Inference

Comments

@ec-m
Copy link
Collaborator

ec-m commented Jun 19, 2019

Right now, only single words like yes, yeah or nope are recognized as yes or respectively no. However, the prop_yesno should also be filled if one says longer phrases like yes that sounds good or no thank you.
@josephbirkner
Copy link
Collaborator

Thanks for reporting! Do you want to add it to your current sprint? @emlozin Do you fancy picking this one up?

@josephbirkner josephbirkner added this to the Inference milestone Jun 23, 2019
@josephbirkner josephbirkner added core ⚙️ Issues that concern the core ravestate lib/API inference 💡 and removed core ⚙️ Issues that concern the core ravestate lib/API labels Jun 23, 2019
@emlozin
Copy link
Collaborator

emlozin commented Jun 23, 2019

@josephbirkner Can do :)

@josephbirkner
Copy link
Collaborator

Thanks!

josephbirkner added a commit that referenced this issue Sep 13, 2019
@josephbirkner
Merge pull request #118 from Roboy/flexible_yesno
dd8420b 
More complicated yes/no detection. Fixes #107
@josephbirkner josephbirkner mentioned this issue Sep 15, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emlozin emlozin

Labels
inference 💡
Projects
None yet
Milestone
Inference
Development

No branches or pull requests
3 participants
@josephbirkner @ec-m @emlozin