Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sub-sampling in raytracing code #277

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

prybicki
Copy link
Collaborator

No description provided.

@prybicki prybicki requested review from PiotrMrozik and msz-rai April 17, 2024 07:45
@prybicki prybicki force-pushed the feature/multi-return-rtx branch from 11b3583 to bde0978 Compare April 23, 2024 11:12
@prybicki prybicki changed the base branch from develop to feature/q2-features April 23, 2024 11:13
@prybicki prybicki force-pushed the feature/multi-return-rtx branch from bde0978 to ed71ef1 Compare April 23, 2024 11:18
Copy link
Collaborator

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
I have left some minor comments to address, but the code looks good 👍

include/rgl/api/core.h Show resolved Hide resolved
src/gpu/optixPrograms.cu Outdated Show resolved Hide resolved
src/gpu/optixPrograms.cu Outdated Show resolved Hide resolved
src/gpu/optixPrograms.cu Outdated Show resolved Hide resolved
src/gpu/optixPrograms.cu Show resolved Hide resolved
src/gpu/optixPrograms.cu Show resolved Hide resolved
src/gpu/optixPrograms.cu Show resolved Hide resolved
src/graph/RaytraceNode.cpp Show resolved Hide resolved
@RobotecAI RobotecAI deleted a comment from msz-rai Apr 24, 2024
@PawelLiberadzki PawelLiberadzki merged commit f0ce4bf into feature/q2-features Apr 24, 2024
20 checks passed
@PawelLiberadzki PawelLiberadzki deleted the feature/multi-return-rtx branch April 24, 2024 09:07
msz-rai pushed a commit that referenced this pull request Jul 13, 2024
* Implement sub-sampling in raytracing code

* Review fixes
msz-rai pushed a commit that referenced this pull request Jul 15, 2024
* Implement sub-sampling in raytracing code

* Review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants