Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taped test #263

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Add taped test #263

merged 14 commits into from
Apr 2, 2024

Conversation

nebraszka
Copy link
Collaborator

@nebraszka nebraszka commented Mar 11, 2024 •
edited
Loading

@nebraszka nebraszka changed the title Add integration test using Tape Add Taped test Mar 11, 2024
@nebraszka nebraszka force-pushed the test/integration-test branch 2 times, most recently from f322f8d to 1470fd7 Compare March 12, 2024 10:41
@nebraszka nebraszka force-pushed the test/integration-test branch from 1470fd7 to 50a3aec Compare March 12, 2024 11:36
@nebraszka nebraszka force-pushed the test/integration-test branch from 50a3aec to 759ea80 Compare March 12, 2024 12:53
@nebraszka nebraszka marked this pull request as ready for review March 19, 2024 14:13
@nebraszka nebraszka force-pushed the test/integration-test branch 2 times, most recently from fa7e6e9 to 888082d Compare March 21, 2024 09:10
@nebraszka nebraszka force-pushed the test/integration-test branch from 888082d to a21eb2e Compare March 21, 2024 09:46
@nebraszka nebraszka force-pushed the test/integration-test branch from 906c1d4 to 03ff697 Compare March 21, 2024 11:02
@nebraszka nebraszka force-pushed the test/integration-test branch from 03ff697 to 6f2aa0a Compare March 21, 2024 11:09
@nebraszka nebraszka requested a review from msz-rai March 21, 2024 11:38
@nebraszka nebraszka changed the title Add Taped test Add taped test Mar 21, 2024
msz-rai
msz-rai reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration 👍
I have left the comments to address.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
test/src/TapedTest.cpp Outdated Show resolved Hide resolved
test/src/TapedTest.cpp Outdated Show resolved Hide resolved
@nebraszka nebraszka force-pushed the test/integration-test branch from 9355470 to 0f00943 Compare April 2, 2024 07:56
@nebraszka nebraszka force-pushed the test/integration-test branch from c4111fe to 53c828c Compare April 2, 2024 10:52
msz-rai
msz-rai reviewed Apr 2, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
test/taped_test/CMakeLists.txt Outdated Show resolved Hide resolved
msz-rai
msz-rai approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nebraszka nebraszka merged commit c1f0a38 into develop Apr 2, 2024
20 checks passed
@nebraszka nebraszka deleted the test/integration-test branch April 2, 2024 16:00
msz-rai pushed a commit that referenced this pull request Jun 11, 2024
@nebraszka @msz-rai
Add taped test (#263)
fd0abc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msz-rai msz-rai msz-rai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebraszka @msz-rai