Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
prybicki committed May 14, 2024
1 parent 54fd38f commit c9b6b75
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion include/rgl/api/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -717,10 +717,11 @@ RGL_API rgl_status_t rgl_node_raytrace_configure_mask(rgl_node_t node, const int
* Modifies RaytraceNode to set beam divergence.
* Beam divergence is used to calculate the beam width at the distance of hit point.
* Setting beam divergence > 0.0f is required to use query for multi-return results.
* Setting beam divergence == 0.0f disables multi-return.
* @param node RaytraceNode to modify.
* @param beamDivergence Beam divergence in radians.
*/
RGL_API rgl_status_t rgl_node_raytrace_configure_beam_divergence(rgl_node_t node, float beamDivergence);
RGL_API rgl_status_t rgl_node_raytrace_configure_beam_divergence(rgl_node_t node, float beam_divergence);

/**
* Creates or modifies FormatPointsNode.
Expand Down
10 changes: 5 additions & 5 deletions src/api/apiCore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -941,16 +941,16 @@ void TapeCore::tape_node_raytrace_configure_mask(const YAML::Node& yamlNode, Pla
rgl_node_raytrace_configure_mask(node, state.getPtr<const int8_t>(yamlNode[1]), yamlNode[2].as<int32_t>());
}

RGL_API rgl_status_t rgl_node_raytrace_configure_beam_divergence(rgl_node_t node, float divergence)
RGL_API rgl_status_t rgl_node_raytrace_configure_beam_divergence(rgl_node_t node, float beam_divergence)
{
auto status = rglSafeCall([&]() {
RGL_API_LOG("rgl_node_raytrace_configure_beam_divergence(node={}, divergence={})", repr(node), divergence);
RGL_API_LOG("rgl_node_raytrace_configure_beam_divergence(node={}, divergence={})", repr(node), beam_divergence);
CHECK_ARG(node != nullptr);
CHECK_ARG(divergence >= 0.0f);
CHECK_ARG(beam_divergence >= 0.0f);
RaytraceNode::Ptr raytraceNode = Node::validatePtr<RaytraceNode>(node);
raytraceNode->setBeamDivergence(divergence);
raytraceNode->setBeamDivergence(beam_divergence);
});
TAPE_HOOK(node, divergence);
TAPE_HOOK(node, beam_divergence);
return status;
}

Expand Down

0 comments on commit c9b6b75

Please sign in to comment.