adressed final remarks from pr #3

.gitignore

@@ -34,3 +34,4 @@
 .idea
 build
 cmake-build-debug
+RGLServerPlugin/include/rgl

RGLServerPlugin/include/RGLServerPluginManager.hh

@@ -98,7 +98,7 @@ namespace rgl {
         ////////////////////////////////////////////// Functions /////////////////////////////////////////////
         ////////////////////////////// Scene ////////////////////////////////
 
-        bool CheckNewLidarsCb(
+        bool RegisterNewLidarsCb(
                 ignition::gazebo::Entity entity,
                 const ignition::gazebo::EntityComponentManager& ecm);
 

RGLServerPlugin/src/Mesh.cc

@@ -51,6 +51,9 @@ const ignition::common::Mesh* RGLServerPluginManager::LoadBox(
     return mesh_manager->MeshByName(UNIT_BOX_TEXT);
 }
 
+//The difference between capsule and other primitive geometry types is
+// that "unit_capsule" mesh is not created by the gazebo MeshManager,
+// while other primitive types have their unit meshes created and ready to query by name
 const ignition::common::Mesh* RGLServerPluginManager::LoadCapsule(
         const sdf::Geometry& data,
         double& scale_x,

RGLServerPlugin/src/RGLServerPluginManager.cc

@@ -39,7 +39,7 @@ void RGLServerPluginManager::Configure(
         ignition::gazebo::EventManager& evm) {
 
     ecm.Each<>([&](const ignition::gazebo::Entity& entity)-> bool {
-                return CheckNewLidarsCb(entity, ecm);});
+                return RegisterNewLidarsCb(entity, ecm);});
 
     ecm.Each<ignition::gazebo::components::Visual, ignition::gazebo::components::Geometry>
             (std::bind(&RGLServerPluginManager::LoadEntityToRGLCb, this, _1, _2, _3));
@@ -55,7 +55,7 @@ void RGLServerPluginManager::PostUpdate(
         const ignition::gazebo::EntityComponentManager& ecm) {
 
     ecm.EachNew<>([&](const ignition::gazebo::Entity& entity)-> bool {
-        return CheckNewLidarsCb(entity, ecm);});
+        return RegisterNewLidarsCb(entity, ecm);});
 
     ecm.EachNew<ignition::gazebo::components::Visual, ignition::gazebo::components::Geometry>
             (std::bind(&RGLServerPluginManager::LoadEntityToRGLCb, this, _1, _2, _3));

RGLServerPlugin/src/Scene.cc

@@ -24,7 +24,7 @@ using namespace rgl;
 #pragma ide diagnostic ignored "ConstantFunctionResult"
 
 // always returns true, because the ecm will stop if it encounters false
-bool RGLServerPluginManager::CheckNewLidarsCb(
+bool RGLServerPluginManager::RegisterNewLidarsCb(
         ignition::gazebo::Entity entity,
         const ignition::gazebo::EntityComponentManager& ecm) {
     auto data = ecm.ComponentData<ignition::gazebo::components::SystemPluginInfo>(entity);