Remove first handler update as queue update is blocked #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queue length for the subscriber isn't set as the code doesn't get that far after setting the throttle rate and returning the updated handler.
Public API Changes
None
Description
Remove the first handle update. The throttle and queue_length stacked methods are still added correctly when updating the second queue_length option, via the conditional statements.
Testing
Without the change: ROS2 debug messages were added (node handle passed to lower classes) and showed the queue_length wasn't being set in `subscription_modifiers.py/MessageHandler.set_queue_length()
With the change added: Ran the bridge with a ROS image publisher and a bridged image subscriber. Setting the throttling rate, changed the image update rates, with or without queue length. Then setting slow throttling (300ms) with a large existing queue showed a long delay in image updates. With a very small queue, throttling effects were immediate.
None