Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS2] port package to ament_cmake, other necessary updates #351

Merged
merged 2 commits into from
Aug 22, 2019
Merged

[ROS2] port package to ament_cmake, other necessary updates #351

merged 2 commits into from
Aug 22, 2019

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Aug 16, 2018 •
edited
Loading

Related to #345.

  • Port the packages from catkin to ament_cmake
  • Use package names to reference builtin types / header
  • Rename the fields which collide with keywords
  • Add migration rules for the changed field names

This PR is still in progress and shouldn't be merged yet.

@dirk-thomas dirk-thomas self-assigned this Aug 16, 2018
@dirk-thomas dirk-thomas changed the base branch from develop to ros2 August 16, 2018 19:00
@dirk-thomas dirk-thomas mentioned this pull request Aug 20, 2018
Closed
@jubeira jubeira mentioned this pull request Feb 5, 2019
Open
24 tasks
@dirk-thomas
Copy link
Contributor Author

@jihoonl Can you grant a colleague of mine the same access as me for this repository? @jubeira has already worked on porting packages in ros2#2 (and we would only use it for the ros2 branch - not touching develop / master). Giving him write access to this repo would make it easier to rebase the ros2 branch and iterate faster without relying on me to do so.

@jihoonl
Copy link
Member

jihoonl commented Jun 13, 2019

ok. Invitation is sent to @jubeira

@jubeira
Copy link

jubeira commented Aug 22, 2019

@dirk-thomas can we merge this branch to ros2 and keep working against that branch? I can do the squash + merge and I'd suggest doing so.

@dirk-thomas
Copy link
Contributor Author

can we merge this branch to ros2 and keep working against that branch? I can do the squash + merge and I'd suggest doing so.

Sounds good to me. Maybe fast forward the ros2 branch with the latest development before?

dirk-thomas and others added 2 commits August 22, 2019 15:37
@dirk-thomas
Initial ROS2 port build changes.
f4ae822 
- Switch from catkin to ament_cmake
- Use package name for builtin types and header
- Rename fields which collide with keywords
- Add ros1_bridge mapping rule
- Use ament_cmake_ros
- Set CMAKE_CXX_STANDARD
Porting rosapi package. (#388)
d4eb55c 
Porting rosapi package.

Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
@jubeira jubeira merged commit 9869364 into ros2 Aug 22, 2019
@jubeira
Copy link

jubeira commented Aug 22, 2019 •
edited
Loading

Done; ros2 branch is now in sync with develop, and these changes were applied on top of it.
Thanks!

@dirk-thomas dirk-thomas deleted the ros2_ament_cmake branch August 22, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @jihoonl @jubeira