-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace removed itemset method #72
Replace removed itemset method #72
Conversation
Numpy 2.0 removes the itemset Python method from the API Switch to setting array values via direct array interface for pybind11::object types Mutable array access is unchecked for dimension boundaries Signed-off-by: John Parent <john.parent@kitware.com>
cc @BetsyMcPhail |
The important test is to open a pull request in https://github.com/RobotLocomotion/drake/pulls that bumps Drake's git sha pin of |
I assume that's essentially the same change I had to make locally, change the repository, commit, and sha? |
Since this is a pull request against the RobotLocomotion repository, you don't need to change the repository. Only the commit and sha256. |
🤦♂️ Good point. PR made. |
+@EricCousineau-TRI do you have time for a feature review pass on this one, please? There are still some failures on the Drake PR, but they do not appear to be related to this PR -- rather just problems with numpy 2.x overall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up, we should add NumPy >= 2 testing
Note that upstream (https://github.com/pybind/pybind11/blob/master/.github/workflows/ci.yml) does test NumPy >= 2, but does it on platforms that we disabled.
I can try to do that as follow-up
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnwparent)
Numpy 2.0 removes the itemset Python method from
the API
Switch to setting array values via direct array
interface for pybind11::object types
Mutable array access is unchecked for dimension
boundaries
Fixes RobotLocomotion/drake#21577
Description
Suggested changelog entry:
This change is