Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install with new bazel 0.5.3 #6736

Merged
merged 3 commits into from
Aug 2, 2017
Merged

Fix install with new bazel 0.5.3 #6736

merged 3 commits into from
Aug 2, 2017

Commits on Aug 2, 2017

  1. Update install providers for Bazel changes 

    Bazel 0.5.x changed the way providers work. Update install and related
rules to use the "new" paradigm.
    @mwoehlke-kitware
    mwoehlke-kitware authored and Francois Budin committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    43c4d89 View commit details
    Browse the repository at this point in the history

  2. Work around possible Bazel providers bug 

    Apparently in newer versions of Bazel (starting with 0.5? As of 0.5.3 at
least...), Bazel doesn't recognize that a provider is the same entity if
one BUILD loads the .bzl file that declares the provider with a
workspace-qualified name, and another omits the workspace qualification.
Since these are the same .bzl, this feels suspiciously like a Bazel bug.
Anyway, work around the issue by always using the workspace-qualified
path.

This should get `bazel build install` working again with Bazel 0.5.3.
    @mwoehlke-kitware
    mwoehlke-kitware authored and Francois Budin committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    d3339d1 View commit details
    Browse the repository at this point in the history

  3. Replace deprecated BazelJavaBuilder flag '-extra_checks' 

    Using the flag '-extra_checks' was generating the following error:
BazelJavaBuilder threw exception: -extra_checks is no longer supported; use\
-XepDisableAllChecks to disable Error Prone
    Francois Budin committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    487a73d View commit details
    Browse the repository at this point in the history