Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings: Remove cpp_const #14270

Merged
merged 1 commit into from
Nov 1, 2020
Merged

bindings: Remove cpp_const #14270

merged 1 commit into from
Nov 1, 2020

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 31, 2020 •
edited by sherm1
Loading

This appears to be dead code. By dropping it, we can also drop an awkward dependency.

This change is Reviewable

@jwnimmer-tri
bindings: Remove cpp_const
d4d1a92 
This appears to be dead code.  By dropping it, we can also drop an
awkward dependency.
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html labels Oct 31, 2020
@jwnimmer-tri
Copy link
Collaborator Author

+@EricCousineau-TRI for both reviews, please.

EricCousineau-TRI
EricCousineau-TRI reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x 2 - sorry about that!

(Had prepped it for cache stuff, but seems like people have seemed good about not using stale / poisoined caches)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)

EricCousineau-TRI
EricCousineau-TRI reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)

EricCousineau-TRI
EricCousineau-TRI reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform)

a discussion (no related file):
BTW This is a backwards-incompatible change - for whatever reason, someone could have been using pydrake.common.cpp_const; however, I'm totes fine with that.

@EricCousineau-TRI EricCousineau-TRI merged commit 432c8db into RobotLocomotion:master Nov 1, 2020
@jwnimmer-tri jwnimmer-tri deleted the rm-cpp_const branch November 1, 2020 17:32
@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricCousineau-TRI EricCousineau-TRI EricCousineau-TRI left review comments

Assignees

@EricCousineau-TRI EricCousineau-TRI

Labels
priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @EricCousineau-TRI