feat: add the settings to disable on X Pro #910

src/_locales/en/messages.json

@@ -111,6 +111,9 @@
     "settingsShowTweetButton": {
         "message": "Display buttons to tweet the results"
     },
+    "settingsEnableOnXPro": {
+        "message": "Run on X Pro"
+    },
     "settingsPleaseReload": {
         "message": "Please reload Twitter once you have changed the settings"
     },

src/_locales/ja/messages.json

@@ -111,6 +111,9 @@
     "settingsShowTweetButton": {
         "message": "結果をツイートするボタンを表示"
     },
+    "settingsEnableOnXPro": {
+        "message": "X Pro上で実行する"
+    },
     "settingsPleaseReload": {
         "message": "設定を変更したらTwitterを再読み込みしてください。"
     },

src/_locales/ko/messages.json

@@ -111,6 +111,9 @@
     "settingsShowTweetButton": {
         "message": "결과 트윗하기 버튼 표시"
     },
+    "settingsEnableOnXPro": {
+        "message": "X Pro에서 실행"
+    },
     "settingsPleaseReload": {
         "message": "설정을 변경한 후 Twitter를 다시 로드해주세요"
     },

src/_locales/zh_TW/messages.json

@@ -111,6 +111,10 @@
     "settingsShowTweetButton": {
         "message": "顯示分享按鈕"
     },
+    "settingsEnableOnXPro": {
+        "message": "在 X Pro 上執行",
+        "description": "This field was translated by machine translation."
+    },
     "settingsPleaseReload": {
         "message": "如更改過設定，請重新載入 Twitter/X"
     },
@@ -171,4 +175,4 @@
     "exitWithoutOpening": {
         "message": "不需要並關閉"
     }
-}
+}

src/ts/browserAction/settingsItems.ts

@@ -1,3 +1,19 @@
+import type { Settings } from "../../types/common/settings";
+import type { TranslationKey } from "../../types/common/translator";
+
+interface SettingsItem {
+    settingsName: keyof Settings;
+    translationKey: TranslationKey;
+    type: "checkbox";
+}
+
+interface SettingsSeparator {
+    translationKey: TranslationKey;
+    type: "separator";
+}
+
+type SettingsItems = (SettingsItem | SettingsSeparator)[];
+
 const SETTINGS_ITEMS = [
     {
         translationKey: "settingsWhereToDisplayCheckResults",
@@ -41,7 +57,12 @@ const SETTINGS_ITEMS = [
         settingsName: "showTweetButton",
         translationKey: "settingsShowTweetButton",
         type: "checkbox"
+    },
+    {
+        settingsName: "enableOnXPro",
+        translationKey: "settingsEnableOnXPro",
+        type: "checkbox"
     }
-] as const;
+] as const satisfies SettingsItems;
 
 export { SETTINGS_ITEMS };

src/ts/common/defaultSettings.ts

@@ -7,6 +7,7 @@ const DEFAULT_SETTINGS = {
     alwaysDetailedView: false,
     enableForOtherUsersProfiles: true,
     enableForOtherUsersTweets: true,
+    enableOnXPro: true,
     showMessagesInUnproblematicProfiles: true,
     showMessagesInUnproblematicTweets: false,
     showNotesInMessages: true,

src/ts/contentScript.ts

@@ -7,6 +7,8 @@ import browser from "webextension-polyfill";
 const main = async (): Promise<void> => {
     const settings = await browser.storage.local.get(DEFAULT_SETTINGS);
 
+    if (["pro.twitter.com", "pro.x.com"].includes(location.hostname) && !settings.enableOnXPro) return;
+
     const translator = new Translator(
         (key, substitutions) => browser.i18n.getMessage(key, substitutions),
         browser.runtime.getURL("image/")

src/types/common/settings.d.ts

@@ -7,4 +7,5 @@ export interface Settings {
     showMessagesInUnproblematicTweets: boolean;
     showNotesInMessages: boolean;
     showTweetButton: boolean;
+    enableOnXPro: boolean;
 }

src/types/common/settings.guard.ts

@@ -16,6 +16,7 @@ export function isSettings(obj: unknown): obj is Settings {
         typeof typedObj["showMessagesInUnproblematicProfiles"] === "boolean" &&
         typeof typedObj["showMessagesInUnproblematicTweets"] === "boolean" &&
         typeof typedObj["showNotesInMessages"] === "boolean" &&
-        typeof typedObj["showTweetButton"] === "boolean"
+        typeof typedObj["showTweetButton"] === "boolean" &&
+        typeof typedObj["enableOnXPro"] === "boolean"
     )
 }